fix: show error reason when installation fails#3855
Conversation
Added error handling for download, extraction, and permission setting.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughBoth installation scripts now wrap download, extract, and configuration steps in explicit failure checks: PowerShell uses try/catch and exits with code 1 on errors; the shell script uses conditional checks that log targeted ERROR messages and exit with status 1. ChangesInstallation Error Handling Across Platforms
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@install.ps1`:
- Around line 108-109: The catch blocks in install.ps1 call plain "exit" (which
returns 0), so change each failing catch to return a non-zero code (e.g.,
replace "exit" with "exit 1" or "exit $LASTEXITCODE") so CI sees failures;
update the three catch clauses in install.ps1 accordingly (the catch blocks that
follow the install/initialization steps) to use a non-zero numeric exit value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 22a28646-c2ec-4d88-8d07-370eaf3bbb52
📒 Files selected for processing (2)
install.ps1install.sh
|
Does not fix the linked issue. Has nothing to do with download/extraction process |
Fixes #3854
Installation scripts now print a specific error reason when a step
fails, instead of silently exiting.
Changes
Summary by CodeRabbit