Skip to content

Signed-off-by: Dileep Kumar Somajohassula dileepharithasa@gmail.com - reactive multi-output: correct per-binding producer lookup + count-mismatch validation #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dileepharithasa wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

Signed-off-by: Dileep Kumar Somajohassula dileepharithasa@gmail.com - reactive multi-output: correct per-binding producer lookup + count-mismatch validation #3202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...stream/src/main/java/org/springframework/cloud/stream/function/FunctionConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,8 +565,15 @@ private void bindFunctionToDestinations(BindableProxyFactory bindableProxyFactor
if (!(resultPublishers instanceof Iterable)) {
resultPublishers = Collections.singletonList(resultPublishers);
}
Iterator<String> outputBindingIter = outputBindingNames.iterator();
long outputCount = StreamSupport.stream(((Iterable) resultPublishers).spliterator(), false).count();
if (!CollectionUtils.isEmpty(outputBindingNames) && outputCount != outputBindingNames.size()) {
throw new IllegalStateException("Reactive function '" + functionDefinition
+ "' produced " + outputCount + " output publisher(s) but " + outputBindingNames.size()
+ " output binding(s) are configured " + outputBindingNames
+ ". Each configured output binding must have a corresponding publisher; "
+ "return a Tuple of Flux/Publisher when binding multiple outputs.");
}
Iterator<String> outputBindingIter = outputBindingNames.iterator();

((Iterable) resultPublishers).forEach(publisher -> {
Flux flux = Flux.from((Publisher) publisher);
Expand All @@ -584,7 +591,7 @@ private void bindFunctionToDestinations(BindableProxyFactory bindableProxyFactor
}
if (message instanceof Message m && m.getHeaders().get("spring.cloud.stream.sendto.destination") != null) {
String destinationName = (String) m.getHeaders().get("spring.cloud.stream.sendto.destination");
ProducerProperties producerProperties = this.serviceProperties.getBindings().get(outputBindingNames.iterator().next()).getProducer();
ProducerProperties producerProperties = this.serviceProperties.getBindings().get(outputBinding).getProducer();
MessageChannel dynamicChannel = streamBridge.resolveDestination(destinationName, producerProperties, null);
if (logger.isInfoEnabled()) {
logger.info("Output message is sent to '" + destinationName + "' destination");
Expand Down