Avoid serving a zero cache after identity failure - #37323
Open
kalayciburak wants to merge 1 commit into
Open
kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
AbstractIdentityColumnMaxValueIncrementer published valueCache and nextValueIndex before the insert/identity loop finished. A failed insert left a zero-filled cache in place, so the next call returned 0 instead of retrying the database. The same path served a partial cache when a later insert in the batch failed. Build the cache locally and publish it only after every identity read succeeds. A failed allocation leaves the previous index unchanged, so the next call retries. Cleanup delete still runs after publish, so a delete failure does not discard ids that were actually allocated. Signed-off-by: Burak KALAYCI <kalayciburak1996@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractIdentityColumnMaxValueIncrementerassignedvalueCacheandnextValueIndexbefore the insert/identity loop finished.If
executeUpdatefailed, the zero-filled cache stayed published. The nextnextLongValue()skipped the database and returned0. A later failure in acacheSize > 1batch had the same shape: the incomplete cache was already visible.The cache is now built locally and published only after every identity read succeeds. A failed allocation leaves the previous index unchanged, so the next call retries. The cleanup
deletestill runs after publish, so a delete failure does not drop ids that were actually allocated.This is the identity-column path (HSQL, Sybase, Derby, SQL Server, MySQL identity). It does not change
MySQLMaxValueIncrementer.Before the fix,
AbstractIdentityColumnMaxValueIncrementerTestsexpected7and got0after a failed insert. After the fix that test, the partial-batch case, andDataFieldMaxValueIncrementerTestspass.