Solis: keep a PV-only inverter in pv_today/pv_power (#4922)

[springfall2008]

This is an automated draft PR generated from issue #4922 — a maintainer should review it before merging.

Fixes #4922

Summary

SolisAPI.automatic_config() built one devices list from the battery-filtered inverters and used it for every arg, so an inverter Solis Cloud reports as having no battery was dropped from the PV totals as well as from battery control. pv_today/pv_power now use a separate pv_devices list covering every discovered inverter — Predbat sums those arg lists, so a PV-only inverter's generation is simply added to the array total. Nothing else changes: num_inverters, inverter_type and all control/battery args stay battery-only, so a PV-only inverter is still never written to.

Per the maintainer's note on the issue, this is the PV half only. load_today/load_power/import_today/export_today/grid_power deliberately stay on the battery inverters, since on a shared-CT installation those registers can overlap between inverters and summing them would risk double-counting. A one-line log names any battery-less inverters folded into the PV totals, and docs/components.md records the split (including the solis_cloud_pv_load_ignore escape hatch for sites that need something different).

Testing

• cd coverage && ./run_pre_commit — all hooks Passed, and the quick suite it runs reported All tests passed (4 slow tests skipped, total time: 107.37s).
• tools/triage_test.sh solis — exit 0, All tests passed.

Two new tests in apps/predbat/tests/test_solis.py (both registered in run_solis_tests()):

• test_automatic_config_keeps_no_battery_inverter_in_pv_totals — a two-inverter site with one "No Battery" unit gets both inverters in pv_today/pv_power, while soc_percent, charge_limit, reserve, grid_power, load_today, load_power, import_today and export_today stay on the battery inverter alone.
• test_automatic_config_pv_totals_unchanged_when_all_have_batteries — with no PV-only inverter present the PV args are unchanged and the new log line is not emitted.

[Copilot]

🟡 Changes recommended

The updated Solis documentation guidance omits load_power from the manual-override instructions for solis_cloud_pv_load_ignore, which can mislead users into an incomplete configuration.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR fixes Solis Cloud auto-configuration so PV-only inverters (reported by Solis Cloud as having no battery) are still included in pv_today / pv_power totals, while remaining excluded from battery/control and load/grid-related arguments to avoid double-counting on shared-CT installations.

Changes:

• Split Solis device selection so pv_today/pv_power use all discovered inverters while control/battery args stay battery-only, and emit a log line when PV-only devices are included in PV totals.
• Add Solis unit tests covering both the mixed battery + PV-only scenario and the all-battery scenario.
• Document the PV-only inverter behavior in the Solis component docs.

File summaries

File	Description
docs/components.md	Documents the PV-only inverter split between PV totals vs battery/control/load/grid behavior.
apps/predbat/solis.py	Adjusts automatic_config() to include PV-only inverters in PV totals without enrolling them as battery inverters.
apps/predbat/tests/test_solis.py	Adds regression tests for the new PV totals behavior and logging.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.