Inline parser driver into ast package#13
Merged
kyleconroy merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
The parser_driver indirection (function-variable injection points and a side-effect import of test_driver) only made sense when pingcap/parser supported both TiDB's full types and a lightweight stub. Marino has a single driver, so the indirection was pure ceremony: a runtime panic in parser.New, a required blank import for users, and *test_driver.X type assertions in callers. Move the driver code into ast/, rename the concrete types that collided with their interfaces (ValueExpr -> ValueExprBase, ParamMarkerExpr -> ParamMarkerExprBase, BinaryLiteral []byte -> BinaryLit), turn ast.New* function-vars into plain functions, and drop the driver-missing panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser_driver indirection (function-variable injection points and a
side-effect import of test_driver) only made sense when pingcap/parser
supported both TiDB's full types and a lightweight stub. Marino has a
single driver, so the indirection was pure ceremony: a runtime panic in
parser.New, a required blank import for users, and *test_driver.X type
assertions in callers.
Move the driver code into ast/, rename the concrete types that collided
with their interfaces (ValueExpr -> ValueExprBase, ParamMarkerExpr ->
ParamMarkerExprBase, BinaryLiteral []byte -> BinaryLit), turn ast.New*
function-vars into plain functions, and drop the driver-missing panic.