Skip to content

Delegate images keychain to toolhive-core - #6147

Open
JAORMX wants to merge 1 commit into
mainfrom
chore/images-keychain-core
Open

Delegate images keychain to toolhive-core#6147
JAORMX wants to merge 1 commit into
mainfrom
chore/images-keychain-core

Conversation

@JAORMX

@JAORMX JAORMX commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Wave 2 adoption: pkg/container/images/keychain.go (env + composite registry keychains) graduated to toolhive-core/container/images in v0.0.37 (stacklok/toolhive-core#206). This PR reduces the local file to a deprecated thin wrapper delegating to core, so the two call sites (pkg/runner/retriever, pkg/container/docker) keep compiling unchanged; the wrapper can be removed in the cleanup wave.

RegistryImageManager stays in toolhive — it is coupled to the moby client end to end (daemon.Write/daemon.Image/ImagePull/ImageBuild) and was deliberately not moved.

Bumps toolhive-core to v0.0.37.

Test plan

  • task build, task lint-fix — clean
  • go test ./pkg/container/... ./pkg/runner/retriever/... — pass

@github-actions github-actions Bot added the size/XS Extra small PR: < 100 lines changed label Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.64%. Comparing base (32f75d9) to head (1823e32).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6147      +/-   ##
==========================================
+ Coverage   72.61%   72.64%   +0.02%     
==========================================
  Files         736      736              
  Lines       76340    76313      -27     
==========================================
+ Hits        55431    55434       +3     
+ Misses      16973    16941      -32     
- Partials     3936     3938       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuv samuv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants