[6.x] Fix video thumbnail generation logging an error on success#14971
Merged
jasonvarga merged 1 commit intoJul 10, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating a video thumbnail runs
ffmpeg, which writes its banner and progress output to stderr even on a successful run. SinceProcess::logErrorOutput()logs any stderr output at error level regardless of the exit code, every successful thumbnail generation still logged an error (surfacing in Sentry, Bugsnag, etc.), and on FFmpeg 8 the image2 muxer additionally warned about the missing-updateoption when writing a single image. This adds-hide_bannerand-loglevel errorso the command only writes to stderr on an actual error, and switches-vframes 1to-frames:v 1 -update 1to write the single frame without the warning.Fixes #14944