[6.x] Fix numbers being considered empty by field conditions - #15257
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HWzPmQoku8u1dA6VMp51RS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where fields with
empty/not emptyconditions targeting an integer field would be hidden, even when the target field had a value.This was happening because the validator's
isEmptyhelper falls through toObject.keys(value).length === 0, andObject.keys()of a number is always an empty array — so any number was considered empty. It only ever appeared to work while typing, since text inputs produce strings (whoseObject.keys()are their character indexes).This PR fixes it by treating numbers as never empty — including
0, since a saved zero is a value rather than an absence.