[6.x] Fix OAuth connections for Eloquent users - #15266
Open
FlxRobole wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OAuth provider disconnect/connect method currently throws a
BadMethodCallException: Call to undefined method App\Models\User::id()error for all eloquent-managed users:Both, the cause and fix for this error is quite similar to #10848: The connect and disconnect methods pass the raw
App\Models\Usermodel to the vendor code that callsid(), which is only available on Statamic user wrappers.(see discussion on discourse)
Reproduction
eloquentuser repository and an auth provider as per statamic docs (tested with azure & github).id()method, obviously).The callback throws the 500 exception.
Fix
User::fromUser()before connecting or disconnecting providers.