Add discriminated union serialization tests - #1860
Draft
jar-stripe wants to merge 1 commit into
Draft
Conversation
Tests discriminated union type shapes for both request-side (TypedDict params with Literal discriminator) and response-side (StripeObject deserialization), covering standalone and inline variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Committed-By-Agent: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Validates that the discriminated union type shapes work correctly in stripe-python before codegen produces these patterns. Covers both request-side (TypedDict params with Literal discriminator) and response-side (StripeObject deserialization).
What?
tests/test_discriminated_unions.pywith 36 tests covering:Literal["value"]discriminator field (request side)StripeObject.construct_fromfor both patternsSee Also
jar/discriminated-unionsbranch (codegen changes)Changelog
No user-facing changes (test-only).