Adds v2-event-imports section to static v2/core/_event.py file - #1861
Open
jar-stripe wants to merge 1 commit into
Open
Adds v2-event-imports section to static v2/core/_event.py file#1861jar-stripe wants to merge 1 commit into
jar-stripe wants to merge 1 commit into
Conversation
file format used in beta and private-preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The latest release includes better types for "open" enums, i.e. enums that can contain values added to the API after the SDK release. These types are declared with typing.Union, but we cannot import Union without actually using it or else we anger the linter. We changed our code generator to expect a dynamic section in v2/core/_event.py to make sure the imports generate correctly. This PR adopts a dynamic section already in our beta and private-preview branches to correspond with that change.
What?
See Also