Repository navigation
perf(cli): drop oxfmt from the compiled binary - #6712
Conversation
Minify, ESM, and bytecode depth 2 shorten compiled startup for local binaries and release builds.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 AI Review
Claude reported no findings. Codex reported one user-guidance nit, which is confirmed: the formatter hint assumes an output filename that the command does not control.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/commands/gen/types/types.handler.ts:359 |
user-guidance |
codex | The formatter hint hardcodes database.types.ts, so it is inaccurate when stdout is redirected to another filename or left in the terminal. |
Stats
Claude findings: 0 · Codex findings: 1 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
In-process gen types TypeScript is no longer formatted. stderr suggests npx oxfmt on the saved file. Linked and project-id TypeScript still come back formatted from the Management API.
98b85d5 to
74f877c
Compare
|
Rebased onto #6708 and resolved all four build-file conflicts. Release, local, and E2E builds retain the shared compile options and the oxfmt stub. The author’s concurrently pushed filename-neutral hint fix was preserved. Formatting, generic and Effect lint, type-checking, all 89 focused generator/handler tests, native compilation, and startup checks pass. A compiled populated-schema probe using the shared options and stub emits valid TypeScript identical to source execution. Foreign-platform execution was not repeated. |
Local and database-URL TypeScript generation now emits the generator’s unformatted output, removing the oxfmt implementation and native addon from the compiled CLI. The CLI explains on stderr that users can format the output after saving it. TypeScript returned by the Management API and Go, Python, and Swift generation are unchanged.
Builds replace the unused typegen formatter import with a stub and retain the shared minification, ESM, and bytecode settings from #6708.