fix(nix): remove pinned Go version in supascan/gatekeeper - #2329
Draft
brainrake wants to merge 3 commits into
Draft
fix(nix): remove pinned Go version in supascan/gatekeeper#2329brainrake wants to merge 3 commits into
brainrake wants to merge 3 commits into
Conversation
go_1_24 is missing in the upcoming nixpkgs 26.05pre bump used by #2328's flake.lock update; go_1_25 is the newest Go version present in both the current and the bumped nixpkgs, so pinning to it keeps these packages building across the update.
PostgreSQL Extension Dependency Analysis: PR #2329
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
pkgs.go already resolves to 1.25.x on both the current and the bumped nixpkgs (25.11pre -> 26.05pre), well above the >= 1.23.2 requirement, so the explicit go_1_24/go_1_25 override was redundant and fragile across nixpkgs bumps. Using plain pkgs.buildGoModule matches how the other Go packages in this flake (goss, pg-startup-profiler, packer, wal-g) are already built.
brainrake
changed the title
PostgreSQL Package Dependency Analysis: PR #2329
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
brainrake
marked this pull request as ready for review
July 31, 2026 04:33
imor
approved these changes
Jul 31, 2026
Collaborator
Author
|
Looks like there is not enough space for test-ami |
This was referenced Aug 1, 2026
brainrake
marked this pull request as draft
August 1, 2026 23:55
Collaborator
Author
|
test-ami-nix (15) fails with out of space error - tracked separately in PSQL-1570, unrelated to this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go_1_24is missing in the nixpkgs 26.05pre bump being pulled in by chore: update flake.lock (monthly) #2328'sflake.lockupdate, breakingnix-evalforchecks.*.supascanon all platforms.pkgs.go(whatpkgs.buildGoModuledefaults to) already resolves to 1.25.1 on the current nixpkgs and 1.25.4 on the bumped one — both well above supascan's>= 1.23.2requirement. This matches how the other Go packages in this flake (goss,pg-startup-profiler,packer,wal-g) are already built, and avoids this whole class of breakage on future nixpkgs bumps.gatekeeper.nix, fixed the same way.Test plan
nix eval .#packages.x86_64-linux.supascan.name/gatekeeper.namesucceed on develop's current nixpkgsnix build .#packages.aarch64-darwin.supascansucceeds,go test ./...passes, output hash matches the pinned-1.25 build (functionally identical)