ci: Delete nix-eval workflow - #2347
Open
mmlb wants to merge 2 commits into
Open
Conversation
I noticed that its taking nix-eval almost 9m to install nix when on my laptop it takes about 8s. Initially I thought it was something in blacksmith and reached out to support. They pointed at nix install (actual nix, not the action) doing chown on /nix as the culprit. Not sure why we are using sticky disks when we have a binary cache we push to and also call nix-eval-jobs with `option eval-cache false`. So seems like we a pure loss. Dropping this brought the nix install action down to 8s and the overall nix-eval from ~10m -> ~3m.
Its only ever used in nix-build workflow and afaics in Actions tab its never been called so just embed it directly here and drop a file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Maintenance
What is the current behavior?
nix-eval is its own workflow but is only used by nix-build and seems to never have been called manually.
What is the new behavior?
No need for its own file, just embed into nix-build.