Repository navigation
Conversation
Shared compat shim (symver pins + dlvsym resolution) for dlopen/dlsym/ dlerror/dlclose, sem_*, shm_*, pthread_sigmask, pthread_getattr_np, fcntl/fcntl64, stat/fstat/lstat family, strtol/strtoul/sscanf/fscanf. Wired into orioledb, supabase-groonga, pgbouncer, pgbackrest. goss and packer instead set CGO_ENABLED=0: confirmed fully static, no glibc dependency at all. Refs: MPG-1326
1 task done
orioledb.nix: keep develop's beta19 bump alongside our NIX_CFLAGS_COMPILE addition.
Everything previously here (shim wiring for orioledb, supabase-groonga, pgbouncer, pgbackrest; CGO_ENABLED=0 for goss, packer) addressed packages that turned out not to need a glibc floor: postgres core and every extension share one glibc from the same build closure, so glibc-version-check no longer checks them (see #2437). Neither this nor the removed changes ever touched supautils or gatekeeper, the two packages that actually still fail the 2.31 floor (MPG-1326) since they're loaded outside that closure. Repurposing this branch to fix those instead. Refs: MPG-1326
extension_custom_scripts.c calls stat() directly, which resolves to GLIBC_2.33 (y2038 refactor) — above supautils's compat floor for legacy pre-nix hosts. struct stat's layout didn't change on 64-bit archs, so __xstat@<floor> is equivalent (same approach already used for atoi/strtol in this same patch, same compat version per arch). Verified: supautils.so's max glibc requirement drops from 2.33 to 2.17 on aarch64-linux (built, linked, and checked against the real 2.31 floor — passes). x86_64's GLIBC_2.2.5 branch mirrors the existing atoi fix's own per-arch structure and is confirmed to exist in glibc's symbol table, but no x86_64-linux builder was available to build/link it here — worth confirming in CI. Refs: MPG-1326
brainrake
changed the title
PostgreSQL Package Dependency Analysis: PR #2523
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
PostgreSQL Extension Dependency Analysis: PR #2523
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
…-remediate-glibc-floor
brainrake
marked this pull request as ready for review
October 8, 2026 12:33
mmlb
requested changes
Oct 8, 2026
mmlb
left a comment
mmlb
left a comment
Collaborator
There was a problem hiding this comment.
no problem with the patch itself but I'd like to see a comment in the .nix file for a removal condition so that we don't carry this forever and ever.
…libc-floor' into martonboros/mpg-1326-remediate-glibc-floor
Package version diffCompares built package versions in legacyPackages between this PR and the tip of the base branch, per system. aarch64-linux: Closure size: 6 -> 6 (2 paths added, 2 paths removed, delta +0, disk usage +0B).x86_64-linux: Closure size: 6 -> 6 (2 paths added, 2 paths removed, delta +0, disk usage +8B). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supautils needs to run on Ubuntu 20.04 glibc (dlopened into legacy postgres). Its existing patch pinned
atoi/strtol;stat()was a separate, unaddressed violation (GLIBC_2.33). Fixed the same way:__xstat/__fxstat/__lxstatpinned to the same per-arch floor already used for atoi/strtol.gatekeeper, originally also in scope, needs no fix — it only ships baked into an AMI at or above the 2.40 floor (see #2437).
Test plan
Refs: MPG-1326