Repository navigation
Conversation
- glibc-collation sorts a fixed corpus under en_US.UTF-8 and C.UTF-8, the only libc locales AMIs and Docker images ship, with the flake's glibc and with glibc 2.40-66, and fails if the order differs. - icu-pin fails evaluation unless postgresql 15, 17, and orioledb-17 link the same ICU 75.1 source, unpatched. - collation-compare runs the same comparison between any two nixpkgs revisions, for any glibc locales. Refs: MPG-1335 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PostgreSQL Extension Dependency Analysis: PR #2535
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2535
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
Drop the all-locales mode and the collation-compare tool. Fingerprint only en_US.UTF-8 and C.UTF-8, and fail when a locale is missing instead of letting sort fall back to C. Refs: MPG-1335 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Refs: MPG-1335
…-collation-testing-2141c0 # Conflicts: # nix/checks.nix
Package version diffCompares built package versions in legacyPackages between this PR and the tip of the base branch, per system. aarch64-linux: Closure size: 372 -> 372 (2 paths added, 2 paths removed, delta +0, disk usage +112B).x86_64-linux: Closure size: 370 -> 370 (2 paths added, 2 paths removed, delta +0, disk usage +112B). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
How?
What
Adds checks that fail when a glibc or ICU change would re-order existing indexes. Databases created since
15.14.1.072/17.6.1.072record glibc 2.40 and ICU 75.1.Each glibc check sorts a fixed corpus under
en_US.UTF-8and compares the output hash with glibc 2.40-66 from nixpkgsfb7944c.glibc-collation: the flake's glibc and locale data. Docker images use this data.ubuntu-24-04-collation: the flake's glibc with locale data built by Ubuntu 24.04'slocaledef, glibc 2.39, as on the AMI.ubuntu-20-04-collation: the same for Ubuntu 20.04, glibc 2.31.icu-pin: fails evaluation unless postgresql 15, 17, and orioledb-17 link the reference ICU 75.1 source with no patches.The corpus is every code point from U+0020 to U+2FFFF, except C1 controls and surrogates, with affixes. That is 1.55M strings.
Verification
On aarch64-linux:
glibc-collationpasses on this branch in about 2 minutes, including the corpus build.ubuntu-24-04-collationandubuntu-20-04-collationpass.ubuntu-24-04-collationfails when the Ubuntu archive is built from a different locale source.icu-pinpasses, and fails evaluation for a postgresql that links ICU 76.1.MPG-1335