Skip to content

2.10.2 - #528

Merged
ianrumac merged 73 commits into
mainfrom
develop
Nov 12, 2026
Merged

2.10.2#528
ianrumac merged 73 commits into
mainfrom
develop

Conversation

@ianrumac

Copy link
Copy Markdown
Collaborator

2.10.2

Fixes

  • Fixes a paywall the app showed right after the same paywall closed being taken off the screen when the closed one finished tearing down.
  • Fixes a crash with DeadObjectException at startup when Google Play's install referrer service died just as the SDK connected to it. The SDK read the referrer in the connection callback, where nothing caught the failure, and didn't use the result. The referrer is now only read where it is needed, for web checkout redemption and install attribution, with error handling.
  • Fixes a paywall that failed to load being reloaded without limit. The limit of three reloads was reset each time a page finished loading, which a failed page also does, so on some devices a paywall that couldn't be reached was reloaded thousands of times in the background, and a paywall on screen could reload in a loop with close and Back not responding. A paywall is now reloaded at most three times per load, after waiting 0.5, 1 and 2 seconds.
  • A failed request for a paywall's font, image or other asset, or for a script from another host, no longer reloads the paywall. Since 2.8.2 any failed request whose URL contained runtime was treated as the whole page failing. Now the page counts as failed only when its own request fails, or when a script served by Superwall fails before the paywall has reported that it is ready.
  • Fixes a subscription that expired or was refunded or revoked while the app was in the background staying active until the app was restarted. When the SDK manages purchases (no PurchaseController), it now rechecks Google Play purchases each time the app returns to the foreground. Web entitlements are also refreshed on return to the foreground when the last check is older than the configured interval

claude and others added 30 commits November 2, 2026 13:33
The only use was awaiting WorkManager.getWorkInfosByTag in
NotificationScheduler. Use WorkManager's getWorkInfosByTagFlow instead,
which drops the transitive full Guava jar from the SDK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAoXMCfJDDrqBG4cYiF
…fixes

Remove kotlinx-coroutines-guava dependency
…hitecture

refactor: add API guard and retire iOS-port leftovers
…acade

refactor: decompose Superwall.kt into a thin facade
…ance-locator

refactor: remove internal Superwall.instance via constructor injection
* Address review findings on 2.10.2

- Drop web entitlements fetched for a user who is no longer current: the
  fetch no longer stores anything itself, and a refresh checks the identity
  before storing, as a background redeem already does.
- Read purchases again after the launch sync when the app came to the
  foreground once that sync had already read them and was waiting for config.
- Only a paywall runtime script (a .js/.mjs under /runtime/ on
  superwalleditor.com) that fails before the paywall is ready fails the page.
  Matching "superwall" in the host matched nearly every paywall request.

Co-Authored-By: Claude <noreply@anthropic.com>

* Treat any request to the paywall runtime as page-level before ready

The runtime is identified by its domain (superwalleditor.com) and the
/runtime path alone, without requiring a script extension.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

@ianrumac

Copy link
Copy Markdown
Collaborator Author

@maple-review-bot

@maple-review-bot

Copy link
Copy Markdown

F3 can be dismissed; my earlier finding missed the loadUrl override. I rechecked the PR diff, retry callback, optimistic-ready path, and surrounding code at 2185958: retries call SWWebView.loadUrl(), which calls prepareWebview() (line 410); that resets paywallReady = false (line 290) before loading the retry. Readiness therefore does not stay true across retries as I claimed; my previous merge-blocking conclusion on that basis was incorrect.

…530)

* Don't take an optimistic Ready as the paywall runtime having started

With optimistic loading a failed page that finishes is marked Ready, which
made a later failed runtime request a resource error. Runtime readiness is
now tracked apart from the loading state, ignores a Ready the SDK announced
itself, and is cleared for every page load, including each fallback URL.

Co-Authored-By: Claude <noreply@anthropic.com>

* Test how SWWebView feeds runtime readiness to its client

Covers the two pieces of wiring the readiness rules depend on: an optimistic
Ready doesn't stop a failed runtime request failing the page, and a fallback
URL starts without the previous page's readiness.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
@maple-review-bot

This comment has been minimized.

@maple-review-bot maple-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 inline note from Maple's review. The score and summary are in the review comment above.

@maple-review-bot

This comment has been minimized.

@maple-review-bot maple-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 inline notes from Maple's review. The score and summary are in the review comment above.

…531)

The org is enabling SHA-pin enforcement and read-only default GITHUB_TOKEN
permissions. Pin every action and reusable workflow to the commit SHA its
current version resolves to (the version is kept as a trailing comment), and
declare explicit permissions for each workflow matching what its jobs do today.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@maple-review-bot

This comment has been minimized.

@maple-review-bot

This comment has been minimized.

ianrumac and others added 4 commits November 12, 2026 12:57
Fonts and images are served under the runtime path too. Counting them
reloaded a paywall for a missing font, which is the bug 2.10.2 fixes.

Co-Authored-By: Claude <noreply@anthropic.com>
A runtime script that failed before ready schedules a reload. If the
paywall then started anyway, the reload threw away a working page.

Co-Authored-By: Claude <noreply@anthropic.com>
The poll and a foreground refresh could fetch side by side, and the
older response could be applied last. A foreground now waits for a fetch
in flight and skips its own if that one succeeded.

Co-Authored-By: Claude <noreply@anthropic.com>
Syncs run side by side and wait for the config after reading, so an
older read could be published over a newer one.

Co-Authored-By: Claude <noreply@anthropic.com>
@maple-review-bot

This comment has been minimized.

@maple-review-bot

maple-review-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Maple review

Nothing to review

Since the previous review, only generated coverage badges changed: branch coverage to 54.5% and coverage to 64.8%. No new production code requires review.

3cf29e7 · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@ianrumac
ianrumac merged commit 54ff40d into main Nov 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants