Skip to content

ci: pin actions to commit SHAs and declare GITHUB_TOKEN permissions - #531

Merged
anglinb merged 2 commits into
developfrom
ci-pin-actions-token-permissions
Nov 12, 2026
Merged

anglinb merged 2 commits into
developfrom
ci-pin-actions-token-permissions

Conversation

@anglinb

@anglinb anglinb commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

The org is enabling SHA-pin enforcement and read-only default GITHUB_TOKEN permissions. This updates the workflows so they keep working once both settings are on:

  • Every non-local uses: (actions and reusable workflows) is pinned to the full commit SHA that its current tag resolves to. The original version is kept as a trailing comment, so no versions change.
  • Every workflow now declares explicit permissions:. Workflows default to contents: read; jobs that push commits or tags are granted contents: write, matching what they do today.

No behaviour changes are intended.

🤖 Generated with Claude Code

The org is enabling SHA-pin enforcement and read-only default GITHUB_TOKEN
permissions. Pin every action and reusable workflow to the commit SHA its
current version resolves to (the version is kept as a trailing comment), and
declare explicit permissions for each workflow matching what its jobs do today.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@maple-review-bot

This comment has been minimized.

@maple-review-bot

maple-review-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge. Only badge percentages changed since the previous review; all displayed and accessible values agree.
no findings · tests not needed · risk low

The latest commit updates branch and line coverage badges by 0.1 percentage points. Both accessible labels and visible values stay consistent; no defects found in the changes since the previous review.

9e8a06c · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@anglinb
anglinb merged commit 31f5995 into develop Nov 12, 2026
1 check passed
@anglinb
anglinb deleted the ci-pin-actions-token-permissions branch November 12, 2026 07:51
ianrumac added a commit that referenced this pull request Nov 12, 2026
* Remove kotlinx-coroutines-guava dependency

The only use was awaiting WorkManager.getWorkInfosByTag in
NotificationScheduler. Use WorkManager's getWorkInfosByTagFlow instead,
which drops the transitive full Guava jar from the SDK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAoXMCfJDDrqBG4cYiF

* refactor: add the public API guard

* refactor: retire iOS-port leftovers (3.5)

* Update coverage badge [skip ci]

* fix: apply requested changes

* refactor: event handler and presentation

* refactor: bootstrap, status and observers

* refactor: remaining blocks

* fix: apply requested changes

* refactor: SuperwallGraph and tracking

* refactor: options, status, identity, config

* refactor: tests and locator guard

* fix: address review findings

* fix: apply requested changes

* refactor: contexts and analytics

* refactor: PurchaseFlow actor

* refactor: RestoreFlow actor

* fix: apply requested changes

* refactor: ObserverModeTracker actor

* fix: apply requested changes

* fix: apply requested changes

* Update coverage badge [skip ci]

* Update coverage badge [skip ci]

* fix: apply requested changes

* Update coverage badge [skip ci]

* fix: apply requested changes

* fix: apply requested changes

* fix: apply requested changes

* refactor: move PaywallView onto actor primitives (#504)

* fix: report the base plan bought in customer info (#506)

* fix: report the base plan bought in customer info

Play's Purchase only names the subscription, so with several base plans
under one subscription, customer info used the first one in the config
and based the expiry on that plan's period.

Save the product bought against its purchase token. When the plan can't
be known, report the subscription ID with no expiry instead of guessing,
and clear plans and expiries stored by earlier versions that can't be
verified. Tokens from before a purchase are never matched to it, so a
deferred plan change doesn't relabel the purchase it replaces.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix storage, network, billing, observer mode, restore and localization bugs (#498)

* Fix storage, network, billing, observer mode, restore and localization bugs

- Cache: user-scope reset via tombstones instead of wiping the host's
  cacheDir; AtomicFile writes; thread-safe memory cache; tombstoned deletes.
- Reset wipes storage before minting the new identity.
- Network wait accepts any transport with INTERNET, uses the default
  network callback and gives up after 30s.
- Product cache is per wrapper instance, never caches misses as errors,
  retries missing ids after 5 minutes, clears on reset.
- Device receipts no longer guess expiry/grace; PURCHASED is SUBSCRIBED,
  PENDING is pending (not revoked). Removes dead latestPurchase().
- Observer mode uses a single in-flight slot, handled once by either path.
- GoogleBillingWrapper is the only BillingClient; AutomaticPurchaseController
  launches flows, acknowledges and queries through it, and the purchase
  result carries the Play purchase.
- Paywall activity finishes when recreated without its paywall.
- Deprecates PaywallOptions.useCachedTemplates.
- Localizes the restore-failed alert and PaywallComposable's error; the
  composable reloads on placement change and no longer throws without an
  Activity.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gApsMVje34EFAktGWwR

* Address review: failed Play reads, observer slot, reset, cache race

- A failed Play read is no longer treated as "no purchases": receipts and
  customer info aren't overwritten and latestSubscriptionState isn't set to
  EXPIRED. Billing gains queryAllPurchasesResult(), which waits for the
  connection and fails instead of returning an empty list.
- Play subscribers stay active through a failed read until a hold date
  (last confirmed + one subscription period), stored separately from the
  user-facing expiry, which stays unknown.
- A new observed purchase replaces one that never reported an outcome and
  tracks it as abandoned, so observer mode can't get stuck.
- After reset/user switch, the new user's receipts are rebuilt from Play.
- Cache: memory updates and queued disk work happen under one lock, and a
  disk read that races clearUserScope doesn't resurrect the old value.
- The billing flow is launched on the main thread.
- CacheInstrumentedTest uses clearUserScope(); the PaywallComposable
  placement test now fails without the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gApsMVje34EFAktGWwR

* Fix CI and address review findings

- Restore gradle versions, wrapper and superwall/build.gradle.kts the IDE downgraded
- Keep restore-failed text the app sets explicitly, even when it equals the English default
- Leave pending purchases out of published purchase history; drop cancelled pending purchases
- Drop expiry dates older versions inferred for stored Play transactions
- Fix GoogleBillingWrapper companion parsed as a companion named 'internal'
- Update API dump and tests for the new billing semantics

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

* Rethrow cancellation in lastSubscriptionProperties; stub view context in restore tests

- F4: a cancelled product lookup no longer computes and publishes a state
- androidTest PaywallView mock provides a context for the localized restore-failed alert

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Read cache files directly so a read can't discard a write in progress

AtomicFile.openRead() deletes the .new file whenever the base exists, which
drops a write the ioQueue is still making to the same key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Schedule notifications for paywalls embedded in the app's Activity (#495)

* Schedule notifications for paywalls embedded in the app's Activity

Trial reminders and the paywall's ScheduleNotification messages were
only scheduled when the paywall was shown in a SuperwallPaywallActivity
or an InWindowPaywallHost. A paywall embedded with PaywallComposable
lives in the app's own Activity, so PaywallNotifications.forPaywall
returned null and the SDK logged a warning instead of scheduling.

forPaywall now falls back to the Activity the view is embedded in
(set by PaywallBuilder.activity). It asks for POST_NOTIFICATIONS with
requestPermissionFrom, the same helper the in-window host uses, so it
works for a ComponentActivity and a plain Activity. The instance is
kept on the PaywallView and outlives cleanup(), so a permission granted
after the composable is released still schedules; a pending request is
released when a lifecycle-aware Activity is destroyed.

🌸 Shipped with Kanna — https://kanna.sh

Co-Authored-By: Kanna <noreply@kanna.sh>
Kanna-Agent: claude/opus

* Update coverage badge [skip ci]

* Update coverage badge [skip ci]

* Don't hold the embedding Activity in cached paywall notifications

The permission request resolves the Activity through a weak reference, so a
destroyed host isn't retained by the PaywallView that PaywallManager caches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Kanna <noreply@kanna.sh>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ian Rumac <ian@superwall.com>
Co-authored-by: Ian Rumac <ian.rumac@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* feat: report FCM push tokens for Superwall notifications (#494)

* feat: report FCM push tokens for Superwall notifications

Adds Superwall.setPushToken(token), optOutOfNotifications(),
optInToNotifications() and handleNotificationOpen(intent | data), mirroring
superwall/Superwall-iOS#571 for the FCM channel.

NotificationTokenManager sends a notification_token event (channel "fcm",
address, permissionStatus, enabled, appVersion, sdkVersion) on token,
permission (re-checked on foreground), opt and identity changes, otherwise at
most once a day, deduped by a SHA-256 fingerprint persisted in app-specific
storage. Nothing is sent until the user_notifications flag is on (the state is
cached and flushed once it is), or while eventTrackingBehavior is NONE.

notification_token and notification_open are PrivateSuperwallEvents: queued
for the collector with $is_standard_event, but never passed to the delegate,
stored on-device or able to trigger a paywall.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix: keep push tokens out of logs and send them once tracking is back on

A failed /events request logged the whole EventsRequest, including the
notification_token address, and Logger delivers every log to
SuperwallDelegate.handleLog. It now logs only the event count and names. A
cache entry that fails to decode no longer logs its contents or the decoding
exception, whose message quotes the JSON it read.

Turning eventTrackingBehavior back on refreshed the token before the events
queue applied the new behavior, so the queue dropped the event while the
manager marked it sent, delaying it to the next day's heartbeat. The queue now
exposes its own behavior as a StateFlow; the manager gates on it and refreshes
when it turns tracking back on, instead of the setter calling refresh.

Docs: setPushToken needs configure first and re-sends daily;
handleNotificationOpen is for taps only, and the intent form needs the sw
extra copied into app-built notifications' tap intents.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test: update notification tests for develop's logging and tracking

* Update coverage badge [skip ci]

* Fix notification heartbeat after clock rollback and dropped registrations

- shouldSend resends when the last send is in the future (clock moved back)
- EventsQueue.enqueueAccepted checks tracking and adds atomically, and reports
  whether the event was kept; the token is only marked sent when it was
- Forget the last send when tracking moves off ALL, since the queue drops
  what it holds then
- Update the API dump for the PR's new public API

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Ian Rumac <ian.rumac@outlook.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Pause preloaded paywall webviews while off screen (#496)

* Pause preloaded paywall webviews while off screen

A preloaded paywall's webview loads off screen and then waits in the cache. A webview that is not in a
window still reports its page as visible, and every webview in the app shares one renderer main thread,
so cached paywalls kept running their requestAnimationFrame, CSS and Lottie animations unseen, slowing
the paywall on screen and the host app. SWWebView only paused <video> and <audio> (MediaPlaybackScript).

SWWebView now calls WebView.onPause() once a paywall it holds is ready while it is off screen
(PaywallView.updateState -> PaywallWebUI.onPaywallReady), and when it is detached, and resumes on attach
and on reload. WebView.onPause() stops timers as well as animation frames, so a preload is paused only
after it reached PaywallLoadingState.Ready; before that it must run to load and accept its templates.

Test: SWWebViewMediaLifecycleTest, a preload stops rendering once it is ready and off screen.

* Only pause a detached paywall webview once it is ready

Pausing on detach stopped the page's timers even when it was still
loading, which left a paywall dismissed mid-load stuck half-loaded in the
cache. Detach now pauses only after the loaded page reached Ready; a
reload clears that. Also moves the new tests onto develop's
testSWWebView helper and records PaywallWebUI.onPaywallReady in the API
dump.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Ian Rumac <ian.rumac@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* Stop logging "Error Evaluating JS" after every paywall message (#510)

* Stop logging "Error Evaluating JS" after every paywall message

WebView.evaluateJavascript passes the script's return value, not an
error. window.paywall.accept64 returns nothing, which Android reports
as the string "null", so every successful post (template variables,
callback results, tracking behavior) logged "Error Evaluating JS" with
java.lang.Exception: null. A Unity customer read it as the reason
their custom callback failed.

Skip a null or "null" result; log any other value as before.

🌸 Shipped with Kanna — https://kanna.sh

Co-Authored-By: Kanna <noreply@kanna.sh>
Kanna-Agent: claude/opus

* Update coverage badge [skip ci]

---------

Co-authored-by: Kanna <noreply@kanna.sh>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix custom store product purchases being dropped from paywalls (#512)

* Fix custom store product purchases being dropped from paywalls (#509)

The products template only listed Play Store products, so a paywall never
learned a custom product's id and posted `purchase` without
`product_identifier`. The parser force-unwrapped that field and the NPE
discarded the whole message batch.

- Send custom store products in the `products` template, with their product
  identifier (the key they're cached under) as `productId`.
- Make `product_identifier` optional; the handler resolves a missing id from
  the paywall product with the message's reference name.
- Skip a single unparseable message instead of dropping the whole batch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Dismiss the paywall when its activity is finished while stopped (#513)

* Dismiss the paywall when its activity is finished while stopped (#501)

When SuperwallPaywallActivity was stopped without finishing and finished
later (e.g. its task cleared from the background), onStop only marked the
paywall closed for background and onDestroy never ran the finishing teardown.
activePaywallVcKey stayed set, so isPaywallPresented stayed true and every
later register() failed with "Paywall Already Presented".

onDestroy now runs the finishing teardown (willDismiss, destroyed with
forceCleanup) when the activity is finishing and onStop didn't already
start it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Fix flaky in-window backdrop-tap dismiss test

The test polled paywallView.state.paywallResult after idling the main
looper, but the full teardown (CleanupAfterDestroy) resets paywallResult
to null. dismissView() runs on a real IO thread, so when it posted the
close before the first idleFor(700), the teardown finished before the
first check and the test timed out. Assert on the PaywallState.Dismissed
the teardown emits instead, which carries the result and close reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Don't track a second paywall_close when a backgrounded paywall is torn down

A paywall stopped without finishing tracks paywall_close and sets
closedForBackground. When its activity is then finished while still
stopped, the finishing teardown tracked another paywall_close with no
paywall_open in between. Skip the teardown's close when the background
close was already tracked, so each time the paywall leaves the screen is
counted once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* Version bump

* Fix chngelog

* Update paywall preload benchmark report [skip ci]

* Redesign the README around agent install (#507)

* Redesign the README around agent install

Match the iOS README: the superwall.com banner, an AI-first tagline,
the single-prompt agent install first, then a manual quick start with
copyable Gradle, manifest, configure and register steps. Badges drop to
version, license and coverage, and the emoji feature table goes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

---------

Co-authored-by: Yusuf Tör <3296904+yusuftor@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ian Rumac <ian@superwall.com>

* Report store CUSTOM on custom store product transaction events (#515)

* Fix custom store product purchases being dropped from paywalls (#509)

The products template only listed Play Store products, so a paywall never
learned a custom product's id and posted `purchase` without
`product_identifier`. The parser force-unwrapped that field and the NPE
discarded the whole message batch.

- Send custom store products in the `products` template, with their product
  identifier (the key they're cached under) as `productId`.
- Make `product_identifier` optional; the handler resolves a missing id from
  the paywall product with the message's reference name.
- Skip a single unparseable message instead of dropping the whole batch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

* Report store CUSTOM on custom store product transaction events

Transaction events for custom products defaulted to PLAY_STORE, so analytics
counted purchases made through the developer's own checkout as Google Play
revenue. Mirrors superwall/Superwall-iOS#552.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Fetch entitlements after a custom store purchase (#516)

A custom product purchase has no Play receipt, so the SDK never asked the
backend for the entitlements the developer's server reported. Run the
background /redeem after a successful custom purchase, as after a Play
purchase. A background redeem whose user changed in flight is dropped
instead of being applied to the new user. Mirrors superwall/Superwall-iOS#552.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

---------

Co-authored-by: Ian Rumac <ian.rumac@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ian Rumac <ian@superwall.com>

* Keep test mode purchases in the status when a selection is active (#522)

* Keep test mode purchases in the status when a selection is active

When the tester had chosen an active entitlement in the modal, the status
was built from the selections alone and dropped the entitlements bought
afterwards. Bought entitlements are now added as active next to the
selections, which keep their chosen state, as on iOS.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Spell out that bought test mode entitlements are active

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

---------

Co-authored-by: Yusuf Tör <3296904+yusuftor@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* ci: let a manual dispatch publish a release (#519)

The tag and release checks only ran on push, so a dispatched run skipped
deploy, tag, release and wrapper notification while reporting success.
The tag check still keeps a version from being published twice.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* Keep the paywall cache's active key pointing at a cached view (#521)

* Keep the paywall cache's active key pointing at a cached view

Removing or replacing the paywall on screen left its key behind, so a view
saved later under the same identifier was taken for the one on screen and
survived removeAll. Every update now clears the key when its view goes,
and setting it to a key with nothing cached leaves nothing active, as on iOS.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

* Update coverage badge [skip ci]

---------

Co-authored-by: Yusuf Tör <3296904+yusuftor@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ian Rumac <ian@superwall.com>

* Buy the base plan for sw-none products instead of the free trial (SW-5453) (#523)

* Buy the base plan for sw-none products instead of the free trial (SW-5453)

RawStoreProduct resolves the paywall product's offer (sw-none to the base plan,
sw-auto to the best offer, a named offer to that offer), and TransactionManager
passes the resolved offer id to the PurchaseController. The base plan has no
offer id, so a sw-none purchase arrived as offerId = null.
AutomaticPurchaseController rebuilt the product with OfferType.from(null),
which is Auto since 2.7.0, so it picked the longest free trial and sent that
token to Play.

The controller now treats a null offerId as no offer. OfferType.from(null)
stays Auto: that is right for parsing a product id with no offer part
("sub:plan"), just not for an offer id that was already resolved.

Documents that a null offerId means the base plan for custom
PurchaseControllers, and adds regression tests for sw-none, sw-auto and a
named offer on a base plan with a trial, plus sw-none on a one-time product
with a discount offer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix horizontal system-bar insets in paywall activity (SW-6374) (#520)

* Fix horizontal system-bar insets in paywall activity (SW-6374)

* Stabilize paywall inset device regression fixture

* Override onNewIntent(Intent) instead of the API 35 ComponentCaller variant

Android 14 and below never call onNewIntent(Intent, ComponentCaller), so
deep links delivered through onNewIntent were ignored there. The API 35
type in the signature also made MockK's reflection over the activity throw
NoClassDefFoundError on API 33, crashing PaywallActivityInsetsTest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Use a strict container mock in PaywallActivityInsetsTest

The test attaches its container mock as the process-wide SuperwallGraph. When
an earlier test in the same process has configured the real SDK (CI shards run
TrackingLogicTest first), that SDK's background work and the Logger reach the
mock. Relaxed answers there mock enums and collections, which makes MockK hook
Enum and AbstractCollection for the whole process; the next Enum.toString() in
the activity lifecycle then overflows the stack and crashes the test run.

The container mock is now strict and stubs only what the activity and Logger
read: the view registry, the options and the delegate adapter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

---------

Co-authored-by: Ian Rumac <ian@superwall.com>
Co-authored-by: Ian Rumac <ian.rumac@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update coverage badge [skip ci]

* Clear fullscreen WebView margins when a cached paywall is reused in a container style

A paywall first shown fullscreen keeps its WebView's inset listener and
side/bottom margins. Reusing it as a modal, drawer or popup left those
margins in place on top of the container's padding. Container styles now
remove the listener and reset the margins.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* 2.10.2: install referrer crash, paywall reload loop, entitlement recheck on foreground (#527)

* Fix DeadObjectException crash in install referrer setup callback

The setup-finished callback read the install referrer and discarded the
result. Play invokes that callback on the main thread after
startConnection has returned, so the try/catch in tryConnecting did not
cover it and a dead Play service crashed the app.

Remove the unused read; the referrer is still read and cached in
getInstallReferrerParams, whose callers handle failures. Also keep
anything thrown in the listener callbacks from reaching the main looper.

Fixes #525

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Stop a failed runtime asset from reloading the paywall forever

Any failed request whose URL contained "runtime" was treated as the page
failing, including a font served from the runtime's path. The reload it
triggered could not hit the retry cap, because the cap was reset each
time the page finished loading and the asset failure arrives after that.

Only the main frame and runtime scripts are page-level now, and the
retry count is reset per setup() rather than per page finish.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Recheck entitlements when the app returns to the foreground

The automatic purchase controller only read Play purchases at launch, on
a purchase update and on restore, so a subscription that expired or was
revoked while the app was in the background stayed active until the
process restarted. It now syncs again on each foreground, and web
entitlements are refreshed when the last fetch is older than the polling
interval.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Move changelog entries to 2.10.2 and bump the version

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Back off between paywall reloads and fail the page only on main-frame errors

A sub-resource's URL no longer decides whether the page failed: paywall
scripts and assets can be served from anywhere, so matching "runtime"
in the URL is dropped and only a main-frame failure is page-level.

Reloads now wait 0.5s, 1s and 2s, and errors that arrive while a reload
is pending don't schedule another. With the retry count no longer reset
on page finish, a load that keeps failing stops after three reloads.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Update coverage badge [skip ci]

* Fail the page when a Superwall script fails before the paywall is ready

A paywall whose own script can't load never starts, so that is a real
failure. It is recognised without a timer, which a starved preload would
trip: the failed request is a .js/.mjs file on a Superwall host and the
paywall hasn't reported ready. Fonts, other assets and third-party
scripts stay resource errors.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Update coverage badge [skip ci]

* Update coverage badge [skip ci]

* Test the paywall reload schedule and the web entitlement refresh

Move the reload cap and backoff out of SWWebView into PaywallLoadRetrier
so they can be tested with a controlled clock, and cover the waits, the
three-reload limit, duplicate errors, and reset and cancel.

Cover refreshWebEntitlementsIfStale for stale, exact-threshold, fresh
and missing fetch dates and for polling not yet started. The polling
context is now replaceable so tests can count the poll's own fetches.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Run the load retrier tests on a scope the test clock drives

advanceUntilIdle doesn't wait for work held only by backgroundScope, so
the scheduled reloads never ran in three of the tests.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Cancel the polling scope after each stale-refresh test

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Cancel stale-refresh polling inside the test body

runTest runs the scheduler dry when the body returns, before any @after,
so a polling loop still alive then never ends and the JVM runs out of
memory. Cancel the redeemer's scope in a finally inside each test.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Copy tracked events before filtering them in a PaywallViewTest case

The test iterated a synchronizedList while other threads were still
adding events, which fails now and then with a
ConcurrentModificationException. Copying the list takes its lock.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CR7gAodLcy3yy93Aagowyi

* Update coverage badge [skip ci]

* Update coverage badge [skip ci]

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Leave a paywall the app took over alone when the closed activity is destroyed (#526)

* Leave a paywall the app took over alone when the closed activity is destroyed

When the app showed a cached paywall view (getPaywall) right after the same
paywall closed, the closed SuperwallPaywallActivity still found that view in
onDestroy, through its registry key and its content view, and cleaned it up:
it came off the app's layout and lost its callback. The activity now only
touches a view that's still in its own window, or in no layout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

* Tell a taken-over paywall by its presentation count, not where it's attached

getPaywall detaches the cached view before the app attaches it, and a view
in no layout counted as the closing activity's, so its teardown could still
wipe it. The view now counts its presentations and the activity compares.
A view left alone also lets go of the old activity and its checkout launcher.

Co-Authored-By: Claude <noreply@anthropic.com>

* Update coverage badge [skip ci]

---------

Co-authored-by: Yusuf Tör <3296904+yusuftor@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ian Rumac <ian@superwall.com>

* Address review findings on 2.10.2 (#529)

* Address review findings on 2.10.2

- Drop web entitlements fetched for a user who is no longer current: the
  fetch no longer stores anything itself, and a refresh checks the identity
  before storing, as a background redeem already does.
- Read purchases again after the launch sync when the app came to the
  foreground once that sync had already read them and was waiting for config.
- Only a paywall runtime script (a .js/.mjs under /runtime/ on
  superwalleditor.com) that fails before the paywall is ready fails the page.
  Matching "superwall" in the host matched nearly every paywall request.

Co-Authored-By: Claude <noreply@anthropic.com>

* Treat any request to the paywall runtime as page-level before ready

The runtime is identified by its domain (superwalleditor.com) and the
/runtime path alone, without requiring a script extension.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

* Update coverage badge [skip ci]

* Don't take an optimistic Ready as the paywall runtime having started (#530)

* Don't take an optimistic Ready as the paywall runtime having started

With optimistic loading a failed page that finishes is marked Ready, which
made a later failed runtime request a resource error. Runtime readiness is
now tracked apart from the loading state, ignores a Ready the SDK announced
itself, and is cleared for every page load, including each fallback URL.

Co-Authored-By: Claude <noreply@anthropic.com>

* Test how SWWebView feeds runtime readiness to its client

Covers the two pieces of wiring the readiness rules depend on: an optimistic
Ready doesn't stop a failed runtime request failing the page, and a fallback
URL starts without the previous page's readiness.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

* Update coverage badge [skip ci]

* ci: pin actions to commit SHAs and declare GITHUB_TOKEN permissions (#531)

The org is enabling SHA-pin enforcement and read-only default GITHUB_TOKEN
permissions. Pin every action and reusable workflow to the commit SHA its
current version resolves to (the version is kept as a trailing comment), and
declare explicit permissions for each workflow matching what its jobs do today.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update coverage badge [skip ci]

* Only fail a paywall page for a runtime script, not any runtime file

Fonts and images are served under the runtime path too. Counting them
reloaded a paywall for a missing font, which is the bug 2.10.2 fixes.

Co-Authored-By: Claude <noreply@anthropic.com>

* Drop a waiting paywall reload once the runtime confirms it is ready

A runtime script that failed before ready schedules a reload. If the
paywall then started anyway, the reload threw away a working page.

Co-Authored-By: Claude <noreply@anthropic.com>

* Run one web entitlements refresh at a time

The poll and a foreground refresh could fetch side by side, and the
older response could be applied last. A foreground now waits for a fetch
in flight and skips its own if that one succeeded.

Co-Authored-By: Claude <noreply@anthropic.com>

* Don't publish a purchase sync that finishes after a later one

Syncs run side by side and wait for the config after reading, so an
older read could be published over a newer one.

Co-Authored-By: Claude <noreply@anthropic.com>

* Update coverage badge [skip ci]

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adedeji Toki <deji@fourfoursoftware.com>
Co-authored-by: Brian Anglin <brianranglin@gmail.com>
Co-authored-by: Kanna <noreply@kanna.sh>
Co-authored-by: Leonardo Bilck <leonardo@plotkids.com>
Co-authored-by: Yusuf Tör <yusuf@yusuftor.co.uk>
Co-authored-by: Yusuf Tör <3296904+yusuftor@users.noreply.github.com>
Co-authored-by: Makisuo <31933546+Makisuo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant