Conversation
This looks like a harmless and useless merge conflict leftover.
This hopefully makes changes more clear.
…e feature During v1.12 development, the paging support for SW360 v20 (api_get_all & friends) was developed in parallel to my SW360Response feature and when merging both, the SW360Response got broken when talking to a v20 server as described in #70. This fixes the api_get_all() path to also support SW360Response. Also adds a short Readme section on how to use it.
Collaborator
Author
|
@t-graf, note that I also added a conceptual fix bringing together the changes of @GMishx regarding v20 support and my SW360Response feature. Initially, I planned to put this to a separate MR, but as it also belongs to the topics which I think should be quickly fixed in v1.12, I included it here. Just let me know if I should better separate the topics into two MRs for separate review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements for recent changes of v1.12.0:
Fixes #70