Skip to content

Improve sample files #1551

Closed as not planned
Closed as not planned

Description

@jacalata
  1. show a way to read credentials better than the command line
  2. fix the incorrect 'paging' used in several samples (server.views.populate_image gives outdated image even with refresh to the datasource #1531)
  3. check the samples as a whole for comprehensive coverage

Activity

  1. added
    infraInfrastructure issues (GitHub, etc)
    on Jan 4, 2025
  2. github-actions commented on Jul 24, 2026

    @github-actions

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. If this is still relevant, please comment to keep it open.

  3. github-actions commented on Aug 8, 2026

    @github-actions

    Closing due to inactivity. If this is still relevant, please reopen or file a new issue.

  4. jacalata commented on Nov 10, 2026

    @jacalata
    ContributorAuthor

    Two of the three items in this issue are done on development:

    • Credentials: the samples read them through resolve_credentials in samples/_shared.py, which supports flags and environment variables and prompts for secrets with getpass instead of taking them on the command line.
    • Paging: the samples that list items (for example explore_datasource.py, explore_favorites.py, explore_webhooks.py, explore_workbook.py and extracts.py) use TSC.Pager. The ones that call .get() directly only print total_available.

    The third item, checking sample coverage as a whole, was never scoped, so it is still open. Please file a separate issue for any specific method that lacks a sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in-progressIssues that are in-progress of being fixedinfraInfrastructure issues (GitHub, etc)staletriagedReviewed by a maintainer; leave closed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions