Skip to content

Remove experimental markers from Worker Deployment RPCs - #850

Open
xepozz wants to merge 1 commit into
temporalio:mainfrom
xepozz:chore/remove-experimental-markers-worker-deployment
Open

Remove experimental markers from Worker Deployment RPCs#850
xepozz wants to merge 1 commit into
temporalio:mainfrom
xepozz:chore/remove-experimental-markers-worker-deployment

Conversation

@xepozz

@xepozz xepozz commented Aug 11, 2026

Copy link
Copy Markdown

What changed?
Drop experimental tags

Why?

It's not experimental anymore.
Also PHP SDK uses this api files to generate PHP classes and every time it adds @experimental tags which was removed several months ago temporalio/sdk-php@3ca71a5

Breaking changes

Server PR

@xepozz
xepozz requested review from a team August 11, 2026 12:06

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ccf5c5d958

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


// Describes a worker deployment version.
// Experimental. This API might significantly change or be removed in a future release.
rpc DescribeWorkerDeploymentVersion (DescribeWorkerDeploymentVersionRequest) returns (DescribeWorkerDeploymentVersionResponse) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate the checked-in OpenAPI descriptions

When consumers use the published OpenAPI artifacts instead of the proto source, these RPCs are still documented as experimental: for example, openapi/openapiv2.json:2852 and openapi/openapiv3.yaml:2575 retain the removed warning for DescribeWorkerDeploymentVersion, with the same stale text remaining on the other affected endpoints. Regenerate and commit both OpenAPI definitions so the intended stability status is reflected consistently.

Useful? React with 👍 / 👎.

@xepozz
xepozz force-pushed the chore/remove-experimental-markers-worker-deployment branch from ccf5c5d to eb803d3 Compare August 11, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant