Remove experimental markers from Worker Deployment RPCs - #850
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccf5c5d958
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // Describes a worker deployment version. | ||
| // Experimental. This API might significantly change or be removed in a future release. | ||
| rpc DescribeWorkerDeploymentVersion (DescribeWorkerDeploymentVersionRequest) returns (DescribeWorkerDeploymentVersionResponse) { |
There was a problem hiding this comment.
Regenerate the checked-in OpenAPI descriptions
When consumers use the published OpenAPI artifacts instead of the proto source, these RPCs are still documented as experimental: for example, openapi/openapiv2.json:2852 and openapi/openapiv3.yaml:2575 retain the removed warning for DescribeWorkerDeploymentVersion, with the same stale text remaining on the other affected endpoints. Regenerate and commit both OpenAPI definitions so the intended stability status is reflected consistently.
Useful? React with 👍 / 👎.
ccf5c5d to
eb803d3
Compare
What changed?
Drop experimental tags
Why?
It's not experimental anymore.
Also PHP SDK uses this api files to generate PHP classes and every time it adds
@experimentaltags which was removed several months ago temporalio/sdk-php@3ca71a5Breaking changes
Server PR