Move the throughput_stress details out of the README - #441
Merged
Conversation
lilydoar
force-pushed
the
lilydoar/stack/21
branch
from
August 5, 2026 20:24
df58f3e to
6114a91
Compare
This was referenced Aug 5, 2026
THardy98
approved these changes
Aug 5, 2026
lilydoar
marked this pull request as draft
August 5, 2026 20:58
lilydoar
marked this pull request as ready for review
August 5, 2026 20:58
lilydoar
enabled auto-merge (squash)
August 6, 2026 17:20
tdeebswihart
approved these changes
Aug 7, 2026
Per-scenario detail was most of the README. The throughput_stress section moves to docs/throughput-stress.md, leaving a pointer and an index entry; generic option and run-flag behavior stays in docs/running.md, which the new page references rather than restates. Two errors in the moved text are corrected rather than carried over: the prose named a sleep-activity option that does not exist (the declared one is sleep-activity-json, which the adjacent example already used), and the manual Nexus endpoint example targeted task queue "throughput_stress:default-run-id" when task queues are "omes-<run-id>", so it could not have worked as written. stack-info: PR: #441, branch: lilydoar/stack/21
lilydoar
marked this pull request as draft
August 7, 2026 18:52
auto-merge was automatically disabled
August 7, 2026 18:52
Pull request was converted to draft
lilydoar
force-pushed
the
lilydoar/stack/21
branch
from
August 7, 2026 18:52
6114a91 to
e928069
Compare
lilydoar
marked this pull request as ready for review
August 7, 2026 18:52
lilydoar
enabled auto-merge (squash)
August 7, 2026 18:53
lilydoar
added a commit
that referenced
this pull request
Aug 7, 2026
Stacked PRs: * #444 * #443 * __->__#442 * #441 --- --- --- ### Report a missed capability probe instead of reading false Feature options are resolved by ResolveFeatureOptions, which only the omes CLI calls. Code driving a scenario as a library — VCR and oss-cicd build a ScenarioInfo and call executor.Run directly — never resolves them, so every feature option reads false and the run omits the feature it was meant to exercise, indistinguishable from a run that worked. The OptionSet now tracks resolution, and reading an unresolved feature reports the option and the call that fixes it. An explicitly supplied value is authoritative without a probe, so only an untouched option is reported, and a failed resolution leaves the set unresolved. OptionSet.Set records a value as deliberately chosen, which is what lets a library caller or a test set an option directly and have it treated like a user passing --option. Also: - ResolveFeatureOptions no longer panics on a nil logger, which library callers are the ones to pass. - A created Nexus endpoint is logged distinctly from a reused one, so an operator can see the run added something to the namespace. FuzzExecutor goes through the same path instead of duplicating it. - Declaring an option both required and capability-gated is rejected: required means the user must supply it, gated means the namespace does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Move the throughput_stress details out of the README
Per-scenario detail was most of the README. The throughput_stress section moves
to docs/throughput-stress.md, leaving a pointer and an index entry; generic
option and run-flag behavior stays in docs/running.md, which the new page
references rather than restates.
Two errors in the moved text are corrected rather than carried over: the prose
named a sleep-activity option that does not exist (the declared one is
sleep-activity-json, which the adjacent example already used), and the manual
Nexus endpoint example targeted task queue "throughput_stress:default-run-id"
when task queues are "omes-", so it could not have worked as written.