Skip to content

runtime: fix leaking GC build with cores scheduler#5520

Merged
aykevl merged 1 commit into
tinygo-org:devfrom
rdon-key:fix-leaking-gc-cores-build
Jul 13, 2026
Merged

runtime: fix leaking GC build with cores scheduler#5520
aykevl merged 1 commit into
tinygo-org:devfrom
rdon-key:fix-leaking-gc-cores-build

Conversation

@rdon-key

Copy link
Copy Markdown
Contributor

Fix the build with -scheduler=cores -gc=leaking.

gc_stack_cores.go was included for the leaking GC, causing duplicate definitions and an undefined reference.

Limit it to GCs that perform stack scanning.

Testing

tinygo build -target=pico -scheduler=cores -gc=leaking .
tinygo build -target=pico -scheduler=cores -gc=conservative .
tinygo build -target=pico -scheduler=cores -gc=precise .

@rdon-key

Copy link
Copy Markdown
Contributor Author

I could not find documentation listing the supported GC modes, so I used the same GC modes as gc_stack_raw.go.

@aykevl aykevl merged commit 09bda77 into tinygo-org:dev Jul 13, 2026
20 checks passed
@aykevl

aykevl commented Jul 13, 2026

Copy link
Copy Markdown
Member

Thanks! Looks good to me.

@rdon-key rdon-key deleted the fix-leaking-gc-cores-build branch July 13, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants