Skip to content

Vouch request: Anshul439 - fix for #4819 (batchTrigger idempotency key not cleared on failure) #4926

Description

@Anshul439

Why do you want to contribute?

I recently set up trigger.dev locally and while exploring the codebase, I reproduced issue #4819, where batchTrigger returns a failed run as isCached=true instead of creating a fresh one when the idempotency key isn't cleared after failure.

I confirmed the bug locally by querying the TaskRun table directly - the failed run still has its idempotencyKey attached with a 30 day expiry, and only one always-failing-task run was created despite two batchTrigger calls with the same key 12 seconds apart.

I'd like to contribute a fix for this, and then take on more issues as I get more familiar with the codebase.

Prior contributions or relevant experience

I've contributed to large codebases at my previous company, though they were closed source. This would be my first open source contribution at this scale. I'm comfortable with TypeScript and have spent time understanding the monorepo structure.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions