RPM builds: fix broken RPM updates for some packages#528
Merged
Conversation
* The old package's %postun section is executed after the new package has been installed. Hence it must not remove files unless it is executed in a clean uninstall. * This had broken RPM updates for packages like libcorefoundation.
Owner
|
Fine, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes problems cleanly updating RPM packages:
%postunsection is executed after the new package has been installed. Hence it must not remove files unless it is executed in a clean uninstall.libcorefoundation(shared libraries were missing after update).Note that this fix will take effect only when RPMs containing it are upgraded. Hence in order to get things going people will need to first uninstall all NS RPMs and then install them (i.e. not updating them). Once that's done, subsequent RPM updates will work.
By the way, once the next version is released it will be worthwhile mentioning this in the release notes, because the last release still contained this problem.