fix: tsci push should find fallback file when no entrypoint#2834
Open
64johnlee wants to merge 3 commits intotscircuit:mainfrom
Open
fix: tsci push should find fallback file when no entrypoint#283464johnlee wants to merge 3 commits intotscircuit:mainfrom
64johnlee wants to merge 3 commits intotscircuit:mainfrom
Conversation
Contributor
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Issue #2797 -
tsci pushfails when noindex.circuit.tsxfile and nomainEntrypointProblem:
tsci pushwould fail with "No entrypoint found" error, whiletsci devwould find a fallback file.Solution: When no entrypoint is found,
tsci pushnow searches for any.tsx,.ts, or.circuit.jsonfile as a fallback (similar to howtsci devworks).Testing
bun test tests/cli/push/Closes #2797