Fix Ticker @implicitNotFound message to reference testkit-available API#4592
Open
mvanhorn wants to merge 1 commit intotypelevel:series/3.7.xfrom
Open
Fix Ticker @implicitNotFound message to reference testkit-available API#4592mvanhorn wants to merge 1 commit intotypelevel:series/3.7.xfrom
Ticker @implicitNotFound message to reference testkit-available API#4592mvanhorn wants to merge 1 commit intotypelevel:series/3.7.xfrom
Conversation
Member
|
Thanks for the PR! We should be able to land this fix in 3.7.x, would you mind retargeting to that branch? Thanks! |
The previous message pointed users at `ticked { implicit ticker => }`, which
is defined in the internal tests module (tests/shared/src/test/scala/cats/
effect/Runners.scala) and is not visible to downstream users of the public
testkit artifact. Replace it with an instruction that uses the constructor
already exported from testkit.
Closes typelevel#1875.
mvanhorn
force-pushed
the
osc/1875-ticker-implicit-notfound
branch
from
9de09ab to
328d694
Compare
Author
|
Done @armanbilge - retargeted onto series/3.7.x and cherry-picked the fix. Diff is still 1+/1- on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1875.
The
@implicitNotFoundmessage onTickerintestkit/shared/src/main/scala/cats/effect/testkit/TestInstances.scalatold users touse \in ticked { implicit ticker =>`. Buttickedis defined only intests/shared/src/test/scala/cats/effect/Runners.scala(and, for property-based variants, intests/shared/src/test/scala/cats/effect/BaseSuite.scala) and is not part of the publishedcats-effect-testkit` artifact. A downstream user picking up the message had no way to follow it.The new message points at the constructor that testkit actually exports:
Doc/ergonomics only; no runtime behavior affected.