Remove unused GetChangedTargetsAndEdges RPC and related types#112
Merged
Conversation
GetChangedTargets covers the same workflow now that distances carry the structural change information. Drops the RPC, its request/response messages, Edge/ChangedTargetsAndEdges types, controller implementation, storage reader, cache-path helper, and the example client branch. The fileDescriptor blob in tango.pb.go is left stale — harmless for RPC calls, will refresh on the next `make proto` run.
4 tasks
|
|
yushan8
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetChangedTargetscovers the same workflow now that distances carry the structural change information.Edge/ChangedTargetsAndEdgestypes, controller implementation, storage reader, cache-path helper, and the example client branch.GetChangedTargetssuitable to be used by SubmitQueue.Stack
This is the bottom of the stack. The follow-up reshapes
GetChangedTargetsitself (collapsingChangeTypeand always computing distances).Test plan
go build ./...go test ./controller/... ./core/common/...