fix: expose MCP query parameters in tool schemas - #2208
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2207
MCP tools backed by FastAPI query parameters now publish those parameters in their input JSON Schema, including
propertiesfor strict tool-calling clients.List of files changed and why
deploy/docker/mcp_bridge.py- Retain each tool route and derive non-body input schemas from FastAPI's OpenAPI parameter metadata.deploy/docker/tests/test_mcp_schema.py- Add a regression test for query-backed MCP tool schemas.How Has This Been Tested?
.venv/bin/pytest -q deploy/docker/tests/test_mcp_schema.py tests/test_issue_1850_mcp_sse.py(12 passed).venv/bin/black --check --target-version py314 deploy/docker/tests/test_mcp_schema.py.venv/bin/ruff check deploy/docker/tests/test_mcp_schema.py.venv/bin/ruff check --select E9,F63,F7,F82 deploy/docker/mcp_bridge.py.venv/bin/python -m py_compile deploy/docker/mcp_bridge.py deploy/docker/tests/test_mcp_schema.pyChecklist: