fix: allow single-label hostnames in deep crawling - #2210
Open
rozin-not-found wants to merge 2 commits into
Open
fix: allow single-label hostnames in deep crawling#2210rozin-not-found wants to merge 2 commits into
rozin-not-found wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2079.
This PR updates the URL validation logic in the deep crawling strategies to accept valid single-label hostnames. Previously,
can_process_url()strictly required a period (.) in the network location (netloc). This incorrectly rejected local development servers (e.g.,http://localhost:8080) and internal Docker services. This strict check has been removed while maintaining the essential scheme and netloc presence validations.List of files changed and why
crawl4ai/deep_crawling/bfs_strategy.py: Removed the"." not in parsed.netloccheck to allow dotless domains.crawl4ai/deep_crawling/bff_strategy.py: Removed the identical dot requirement for consistency across strategies.How Has This Been Tested?
can_process_url()against single-label hostnames likehttp://localhost:8080.ValueError, while still properly rejecting completely invalid formats.Checklist: