Remove -k flag from notification agents using public APIs

[Sacred-Shadow]

The -k flag disables TLS certificate validation in curl. Among the existing notification agents, I found 7 that call public APIs with valid SSL certificates but still use -k unnecessarily.

Affected agents: Boxcar, Join, Prowl, Pushbullet, Pushover, Pushplus, ServerChan.

I was able to reach all 7 APIs and confirmed that each one presents a valid SSL certificate.
There is therefore no reason to use -k.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced TLS certificate verification for notification services (Boxcar, Join, Prowl, Pushbullet, Pushover, Pushplus, ServerChan) to enforce valid certificates and improve notification system security.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e9a7dd2c-fdb3-46ba-8160-ef8219da765f

📥 Commits

Reviewing files that changed from the base of the PR and between 16bff4a and 9860d72.

📒 Files selected for processing (7)

• emhttp/plugins/dynamix/agents/Boxcar.xml
• emhttp/plugins/dynamix/agents/Join.xml
• emhttp/plugins/dynamix/agents/Prowl.xml
• emhttp/plugins/dynamix/agents/Pushbullet.xml
• emhttp/plugins/dynamix/agents/Pushover.xml
• emhttp/plugins/dynamix/agents/Pushplus.xml
• emhttp/plugins/dynamix/agents/ServerChan.xml

---

Walkthrough

Seven notification agent scripts in the dynamix plugin were updated to enforce TLS certificate verification by removing the -k flag from curl commands. The flag previously disabled certificate validation; all other request parameters, HTTP methods, endpoints, and output handling remain unchanged.

Changes

Cohort / File(s)	Summary
TLS Certificate Verification Enhancement emhttp/plugins/dynamix/agents/Boxcar.xml, emhttp/plugins/dynamix/agents/Join.xml, emhttp/plugins/dynamix/agents/Prowl.xml, emhttp/plugins/dynamix/agents/Pushbullet.xml, emhttp/plugins/dynamix/agents/Pushover.xml, emhttp/plugins/dynamix/agents/Pushplus.xml, emhttp/plugins/dynamix/agents/ServerChan.xml	Removed the -k flag from curl invocations in all notification agent scripts, enabling TLS certificate verification. Request methods, endpoints, headers, payloads, and output redirection remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Seven agents now stand tall with trust,
No more -k flags—security's a must!
Certificates verified, connections made tight,
Notifications fly safely through the night! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing the -k flag from notification agent scripts. It clearly identifies both the action (remove -k flag) and the scope (notification agents using public APIs), which aligns with all seven files modified in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Sacred-Shadow]

Are you interested in that or should it be withdrawn? Eli Bosley (@elibosley)

[ljm42]

This LGTM