fix: don't print empty line to stderr when Exit message is empty#2310
Merged
dearchap merged 1 commit intourfave:mainfrom Apr 16, 2026
Merged
fix: don't print empty line to stderr when Exit message is empty#2310dearchap merged 1 commit intourfave:mainfrom
dearchap merged 1 commit intourfave:mainfrom
Conversation
HandleExitCoder unconditionally prints the error to ErrWriter,
causing an empty line on stderr when Exit("", code) is used.
Check if the error message is non-empty before printing.
Add test to verify no output for empty exit messages.
Fixes urfave#2263
dearchap
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2263
Problem
HandleExitCoderunconditionally prints the error toErrWriter, causing an empty line on stderr whenExit("", code)is used:This was introduced in #2237.
Fix
Check if the error message is non-empty before printing to
ErrWriter. The exit code is still passed toOsExiterregardless.Test
Added
TestHandleExitCoder_ExitCoderEmptyMessageto verify no output is written when the message is empty.