Repository navigation
fmt: propagate read errors instead of silently treating them as EOF - #12430
Merged
Merged
Conversation
|
GNU testsuite comparison: |
gabrielhnf
force-pushed
the
fix-fmt-error-propagation
branch
from
May 21, 2026 22:21
3101fed to
db48aa6
Compare
RenjiSann
reviewed
Jul 17, 2026
gabrielhnf
force-pushed
the
fix-fmt-error-propagation
branch
2 times, most recently
from
October 23, 2026 18:19
1900c70 to
19512c1
Compare
RenjiSann
reviewed
Nov 11, 2026
sylvestre
force-pushed
the
fix-fmt-error-propagation
branch
from
November 14, 2026 03:28
19512c1 to
c40cdc7
Compare
gabrielhnf
force-pushed
the
fix-fmt-error-propagation
branch
4 times, most recently
from
November 15, 2026 13:11
2f10067 to
9c29cde
Compare
sylvestre
reviewed
Nov 15, 2026
gabrielhnf
force-pushed
the
fix-fmt-error-propagation
branch
from
November 16, 2026 01:10
9c29cde to
067a6c3
Compare
sylvestre
force-pushed
the
fix-fmt-error-propagation
branch
from
November 16, 2026 14:42
067a6c3 to
7c09843
Compare
RenjiSann
force-pushed
the
fix-fmt-error-propagation
branch
from
November 18, 2026 16:05
7c09843 to
3c9121c
Compare
RenjiSann
enabled auto-merge (rebase)
November 18, 2026 16:06
|
Binary size comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10581
FileLinesiterator was silently swallowing IO errors by returning None on any read failure, making them indistinguishable from end-of-file. This caused fmt to exit successfully with code 0 when reading files that produce IO errors, such as/proc/self/mem.Changes:
FileLines::Itemis nowResult<Line, std::io::Error>, propagating read errors to callersParagraphStreamErrorenum to distinguish between unformatted passthrough lines and IO errorsParagraphStream::Itemis nowResult<Paragraph, ParagraphStreamError>process_filenow returns an error onParagraphStreamError::IoErrorinstead of iterating over an empty stream$ fmt /proc/self/memfails with exit code 1.