Skip to content

sort: reject --parallel non-zero#13024

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:sort-p
Jun 22, 2026
Merged

sort: reject --parallel non-zero#13024
cakebaker merged 1 commit into
uutils:mainfrom
oech3:sort-p

Conversation

@oech3

@oech3 oech3 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Closes #13016

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/rm/isatty (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Jun 22, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.19%

❌ 2 regressed benchmarks
✅ 321 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_ascii_c_locale 16 ms 16.7 ms -4.72%
Simulation sort_long_line[10000] 422.6 µs 438.7 µs -3.65%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:sort-p (5e8c3eb) with main (8520cea)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 marked this pull request as ready for review June 22, 2026 12:32
@cakebaker cakebaker merged commit 96f6f4d into uutils:main Jun 22, 2026
173 of 175 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@oech3 oech3 deleted the sort-p branch June 22, 2026 15:01
@oech3

oech3 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Incorrect PR title...

@cakebaker

Copy link
Copy Markdown
Contributor

I fixed the commit message when I merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sort: --parallel succeeds on a non-numerical value

2 participants