Repository navigation
utmpx: share the lock wait budget across records - #16285
Open
mattsu2020 wants to merge 4 commits into
Open
mattsu2020 wants to merge 4 commits into
mattsu2020 wants to merge 4 commits into
Conversation
This was referenced Nov 8, 2026
mattsu2020
force-pushed
the
utmpx/shared-lock-wait-budget
branch
from
November 8, 2026 15:09
ab5cda9 to
c763fae
Compare
mattsu2020
marked this pull request as ready for review
November 8, 2026 15:10
Contributor
Merging this PR will not alter performance1 warning, 1 note
Comparing Footnotes
|
Open and validate a nonblocking descriptor, then select it for libc via /proc/self/fd. Keep getutxent for record reads and locking. Cover FIFO rejection, path replacement, invalid inputs and cleanup.
Use one test-only helper for the uucore unit tests and who FIFO test. Keep the helper inside uucore so it is included in the crate package.
mattsu2020
force-pushed
the
utmpx/shared-lock-wait-budget
branch
from
November 10, 2026 06:35
c763fae to
cb242d0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit Linux utmp record-lock waits to a shared ten-second budget per iterator, so contention on successive records cannot restart the full timeout. Test the policy with a short private budget instead of making the suite wait ten seconds.
Depends on #16284 and #16233. Review this change.