Repository navigation
ci: streamline workflow caching & manage ressources - #16287
anastygnome wants to merge 1 commit into
Conversation
c500c24 to
593ca8e
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
cc: @oech3 |
593ca8e to
f3f7fd3
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Binary size comparison: |
f3f7fd3 to
9df0d0c
Compare
|
GNU testsuite comparison: |
|
Can we share caches even if we don't have |
2d94cf7 to
cc1b845
Compare
Yep, done. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
cc1b845 to
59ad3a6
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
59ad3a6 to
ff29b8f
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
8075102 to
389ce4c
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
389ce4c to
b1ee7bf
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
| - uses: ./.github/actions/rust-cache | ||
| with: | ||
| key: bench-${{ matrix.package }}-${{ matrix.type }} | ||
| save-if: false |
There was a problem hiding this comment.
this key is per package with save-if false, even on main, so nothing ever writes it and the restore always misses, no?
| with: | ||
| workspaces: "fuzz -> target" | ||
| key: fuzz-${{ matrix.target.name }} | ||
| save-if: false |
There was a problem hiding this comment.
same here: fuzz-<target> is never saved anywhere, so this cache is dead. Did you mean to reuse the fuzz-build key?
There was a problem hiding this comment.
yes, fuzz-run now reuses fuzz-build (from the namespace) from the main branch
| shell: bash | ||
| run: | | ||
| echo "RUSTC_WRAPPER=sccache" >> "$GITHUB_ENV" | ||
| echo "SCCACHE_GHA_ENABLED=true" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
sccache still writes from every PR, and it creates far more cache entries than rust-cache. Should it be read-only outside main too?
There was a problem hiding this comment.
SCCACHE_GHA_RW_MODE is now RW on the main branch & RO elsewhere
| # Test building with make | ||
| if (test -z "\$FAULT"); then | ||
| echo "::group::cargo clean before make" | ||
| if ! cargo clean; then |
There was a problem hiding this comment.
unrelated to caching, please split. Also, why run cargo clean twice?
| DOCKER_OPTS: '--volume /etc/passwd:/etc/passwd --volume /etc/group:/etc/group' | ||
| strategy: | ||
| fail-fast: false | ||
| max-parallel: 6 |
There was a problem hiding this comment.
21 jobs at 6 at a time will make every PR much slower. Do we really need this?
|
|
||
| on: | ||
| pull_request: | ||
| paths: &l10n_paths |
There was a problem hiding this comment.
are some of these jobs required checks? With a paths filter they would stay pending on PRs that skip them.
| name: Fuzz (${{ matrix.target.name }}) | ||
| needs: detect | ||
| if: needs.detect.outputs.targets != '[]' | ||
| needs: [detect, fuzz-build] |
There was a problem hiding this comment.
fuzz-build only saves on main, so on PRs this just makes fuzz-run wait for the build. Why the new dependency?
b1ee7bf to
4fc9f1c
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
@sylvestre had forgotten to push one commit ... rebased |
4fc9f1c to
b638cba
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
b638cba to
8b031f0
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
8b031f0 to
8df0bd2
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
@sylvestre lgtm |
8df0bd2 to
66d577a
Compare
Reduce CI cache churn and redundant workflow work.
Adds shared Rust caching with explicit namespaces and default-branch-only writes, limits matrix fan-out, removes redundant single-entry matrices, and filters localization runs.
Refs #10535
Refs #10347
Refs #9315