Skip to content

freebsd.yml: speedup tests - #16341

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:freebsd-z
Open

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:freebsd-z

Conversation

@oech3

@oech3 oech3 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Build test binaries on Ubuntu and run them on slow VMs.
Actually used features (except for openssl) should be pulled by feat_os_unix or something else and make's logic is already tested at different place.

Note that VM action already have issues about propergation of exit code and build error of crated due to failure of downloading crates.

@oech3

oech3 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Oh wait! We were not testing binaries with openssl actually...

@sylvestre

Copy link
Copy Markdown
Contributor

thanks for the patch!
The cargo test runs on the VM don't set FAULT, so their failures don't fail the job (see the inline comment). Please also keep retries for flaky tests, since dropping nextest removes them.

Comment thread .github/workflows/freebsd.yml Resolved
Comment thread .github/workflows/freebsd.yml Resolved
Comment thread .github/workflows/freebsd.yml Resolved
@oech3

oech3 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

retries for flaky tests might difficult since 1 binary contains many tests... But I'l investigate.
Note that freebsd.yml's propagation for exit code was already broken (even with FAULT=1).

@oech3
oech3 force-pushed the freebsd-z branch 3 times, most recently from db93d86 to 9d994b2 Compare November 11, 2026 18:32
@oech3
oech3 requested a review from sylvestre November 11, 2026 19:02
@oech3

oech3 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

One of a way to retry them is nextesting on VM if 1st test failed which would be slow.
(Maybe, impossible to reuse crates built on Ubuntu?)
I want to deffer implementing it until tests and exit code issue was fixed.

Comment thread .github/workflows/freebsd.yml Resolved
@oech3
oech3 force-pushed the freebsd-z branch 5 times, most recently from be753d8 to 086a8e9 Compare November 12, 2026 05:29
@oech3

This comment was marked as resolved.

@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.49 MB (+108 KB, +0.07%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@oech3
oech3 force-pushed the freebsd-z branch 2 times, most recently from f540a9d to 2d1ee8f Compare November 18, 2026 02:35
@oech3
oech3 force-pushed the freebsd-z branch 5 times, most recently from 1e3e173 to bacabeb Compare November 18, 2026 08:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants