Skip to content

utmpx: load the opt-in logind backend at runtime - #16478

Open
mattsu2020 wants to merge 2 commits into
uutils:mainfrom
mattsu2020:utmpx/runtime-logind-loader
Open

mattsu2020 wants to merge 2 commits into
uutils:mainfrom
mattsu2020:utmpx/runtime-logind-loader

Conversation

@mattsu2020

Copy link
Copy Markdown
Contributor

Load the existing opt-in logind backend through libsystemd.so.0 at runtime instead of linking it at build time. Keep the current feature names, record API and source-selection behavior, and test missing libraries and symbols.

Split from #11579; related to #8376. The default-utmp fallback remains in #11579.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@codspeed

codspeed Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will regress 3 benchmarks

2 warnings, 1 note

⚠️ 125 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 1 improved benchmark
❌ 3 regressed benchmarks
✅ 405 untouched benchmarks
🆕 4 new benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation socket_addrs_direct[100000] 104.8 µs 132.3 µs -20.8%
❌ CPU Simulation hostname_ip_lookup[100000] 155.7 µs 185.7 µs -16.14%
❌ Memory tr_ascii_range_lower_to_upper 131.8 KB 138.5 KB -4.81%
⚡ Memory factor_small_factors_and_a_large_prime 104.8 KB 15.4 KB ×6.8
🆕 Memory factor_batch_of_largest_u64s N/A 796 KB N/A
🆕 Memory factor_batch_of_semiprimes N/A 199.5 KB N/A
🆕 Memory factor_batch_of_small_numbers N/A 7.5 MB N/A
🆕 Memory factor_batch_of_smallest_u128s N/A 885.9 KB N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mattsu2020:utmpx/runtime-logind-loader (35ceb50) with main (c44859c)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (6296cb7) during the generation of this report, so c44859c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sylvestre
sylvestre force-pushed the utmpx/runtime-logind-loader branch 2 times, most recently from 35ceb50 to 41d9827 Compare November 18, 2026 04:52
@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.50 MB (+116 KB, +0.07%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@sylvestre
sylvestre force-pushed the utmpx/runtime-logind-loader branch from 41d9827 to b16ae58 Compare November 19, 2026 11:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants