Repository navigation
Conversation
The dummy "sh" inherited stdin, so on OpenBSD CI, where the job script is piped into sh, it read and ran the rest of the script (uucore tests, make, cargo clean) concurrently, randomly deleting the doctests' rlibs. Use sleep with a null stdin, and plain seconds as BSD sleep rejects "999d".
Contributor
|
There is no real consumers of |
Contributor
|
Or it is possible to run |
Contributor
Author
|
This was just for experiment :) |
Contributor
|
I remove other |
Contributor
|
Maybe, |
Contributor
Author
|
Served its purpose, the fix is in #16563. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for merging.
The OpenBSD job fails about half the time with
extern location for libc does not existin the uucore doctests. The rlibs are there when the uucore test binary links and gone a second later. It started with the openssl 0.10.82 bump (ffebb7a).This splits
cargo test --all-features -p uucoreinto--no-run,--liband--docand lists target/debug/deps between them, to see which phase deletes the files.