Repository navigation
utmpx: canonicalize logind host names - #16569
mattsu2020 wants to merge 2 commits into
Conversation
57f7e53 to
e712ae5
Compare
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 4.44%2 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
| // Simple implementation - just return the host as-is | ||
| // Could be enhanced with DNS lookup like the original | ||
| self.record.host.clone() | ||
| self.try_canon_host().unwrap_or_else(|_| self.host()) |
There was a problem hiding this comment.
nobody calls this one anymore, could we just keep a single canon_host returning a Result, like Utmpx::canon_host?
There was a problem hiding this comment.
Unified them into a single canon_host() method.
|
Binary size comparison: |
Related to #8376. Split from #11579.