Skip to content

install, split: fix broken tests on OpenBSD - #16614

Closed
cakebaker wants to merge 2 commits into
uutils:mainfrom
cakebaker:openbsd_fix_tests
Closed

cakebaker wants to merge 2 commits into
uutils:mainfrom
cakebaker:openbsd_fix_tests

Conversation

@cakebaker

@cakebaker cakebaker commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes two recently added tests that fail on OpenBSD:

  • it gates an assert in an install test as umask returns a slightly different value on OpenBSD
  • it disables a split test as head on OpenBSD has no -c option

It should make the OpenBSD job in the CI green again.

@oech3

oech3 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

We should not assume consumer's default umasks.

Also those tests are fixed at #16581 and #16603 .

@cakebaker

Copy link
Copy Markdown
Contributor Author

@oech3 thanks for the hint, closing this PR.

@cakebaker cakebaker closed this Nov 17, 2026
@cakebaker
cakebaker deleted the openbsd_fix_tests branch November 17, 2026 09:41
@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.49 MB (+108 KB, +0.07%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants