Repository navigation
nice: omit from the default WASI build - #16621
Conversation
58abe2f to
482e280
Compare
|
Hey @oech3 , thanks for taking a look! I agree this can be a small change in Cargo.toml. I originally changed the cargo tree command so CI would pick the same packages as the WASI build. I added the --list check to catch nice getting pulled back in later, and the docs note was there to explain why it was missing for easy understanding. I’ve taken those out and dropped the new feature. The PR now moves nice out of the shared list and keeps it in the existing native feature lists. I also reverted the default feature change and squashed the commits. I reran the checks on the smaller patch too. All 16 native nice tests passed, and both WASI previews built successfully with nice absent from -list. Thanks for pointing me toward the simpler change. hope this helps!! |
db39ab4 to
56571ae
Compare
|
We also need to properly gate |
|
Binary size comparison: |
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 4.17%2 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
Thanks for your PR! |
On WASI,
nicereported0even when the host launched Wasmtime at niceness1. Remove it fromfeat_wasmand keep it in the native feature set.Native Linux: 16
nicetests passed. Inherited and applied niceness both reported1.WASI Preview 1 and 2 (Wasmtime 50.0.2): builds passed,
--listomittednice, and direct invocation exited1withunknown program.Addresses #16595 for
nice.