Skip to content

nice: omit from the default WASI build - #16621

Merged
cakebaker merged 1 commit into
uutils:mainfrom
unspecifiedcoder:work/16595-omit-nice-from-wasi
Nov 19, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
unspecifiedcoder:work/16595-omit-nice-from-wasi

Conversation

@unspecifiedcoder

Copy link
Copy Markdown
Contributor

On WASI, nice reported 0 even when the host launched Wasmtime at niceness 1. Remove it from feat_wasm and keep it in the native feature set.

Native Linux: 16 nice tests passed. Inherited and applied niceness both reported 1.
WASI Preview 1 and 2 (Wasmtime 50.0.2): builds passed, --list omitted nice, and direct invocation exited 1 with unknown program.

Addresses #16595 for nice.

Comment thread Cargo.toml Resolved
Comment thread Cargo.toml Resolved
@unspecifiedcoder
unspecifiedcoder force-pushed the work/16595-omit-nice-from-wasi branch from 58abe2f to 482e280 Compare November 17, 2026 11:44
@unspecifiedcoder

Copy link
Copy Markdown
Contributor Author

Hey @oech3 , thanks for taking a look! I agree this can be a small change in Cargo.toml.

I originally changed the cargo tree command so CI would pick the same packages as the WASI build. I added the --list check to catch nice getting pulled back in later, and the docs note was there to explain why it was missing for easy understanding. I’ve taken those out and dropped the new feature. The PR now moves nice out of the shared list and keeps it in the existing native feature lists.

I also reverted the default feature change and squashed the commits.

I reran the checks on the smaller patch too. All 16 native nice tests passed, and both WASI previews built successfully with nice absent from -list. Thanks for pointing me toward the simpler change.

hope this helps!!

@unspecifiedcoder
unspecifiedcoder force-pushed the work/16595-omit-nice-from-wasi branch from db39ab4 to 56571ae Compare November 17, 2026 12:07
@xtqqczze

Copy link
Copy Markdown
Collaborator

We also need to properly gate nice so we don't compile it on WASI: #16632.

@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.49 MB (+108 KB, +0.07%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/env/env0-from is no longer failing!

@codspeed

codspeed Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 4.17%

2 warnings, 1 note

⚠️ 124 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 5 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 2 improved benchmarks
❌ 3 regressed benchmarks
✅ 260 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation socket_addrs_direct[100000] 104.8 µs 131.7 µs -20.41%
❌ CPU Simulation hostname_ip_lookup[100000] 155.7 µs 184.3 µs -15.49%
❌ CPU Simulation df_deep_directory 886.7 µs 927.7 µs -4.42%
⚡ Memory cp_recursive_deep_tree[(120, 4)] 699.2 KB 581.2 KB +20.31%
⚡ CPU Simulation du_deep_tree[(100, 3)] 1.8 ms 1.7 ms +4.48%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing unspecifiedcoder:work/16595-omit-nice-from-wasi (56571ae) with main (c44859c)2

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (1957c76) during the generation of this report, so c44859c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@cakebaker
cakebaker merged commit a663b44 into uutils:main Nov 19, 2026
197 of 204 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants