Repository navigation
expand: accept a zero +N or /N after a tab list - #16637
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Binary size comparison: |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expand -t 4,+0failed withtab size cannot be 0. GNU accepts it, and so does ourunexpand. After a tab list,+0or/0sets no tab size: a later number still gives one (4,+0,8acts like4,+8), and if none does, the list is used as given (4,+0acts like4).tabstops_parsenow skips such a zero instead of failing. After the loop, a+//that never got a number no longer turns the last tab stop into a tab size. That also fixes2,6,+, which spaced every column after 6 by 6 instead of using single spaces as GNU does. A standalone+0or/0still fails as before.The test covers
4,+0,4,/0,2,6,+0,2,6,/0,4,+0,8,4,+0,+2,4,/0,10and2,6,+, with the outputs of GNUexpand(coreutils 8.32, the version I have locally). It fails onmain.AI disclosure: written with help from Claude Code. Nothing was derived from GNU source.
🤖 Generated with Claude Code