Repository navigation
dd: extend a sparse output before syncing it - #16641
Open
yunusarda-sudo wants to merge 1 commit into
Open
yunusarda-sudo wants to merge 1 commit into
yunusarda-sudo wants to merge 1 commit into
Conversation
|
Binary size comparison: |
yunusarda-sudo
force-pushed
the
dd-extend-sparse-before-sync
branch
from
November 18, 2026 16:32
773be17 to
e677211
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
conv=sparse,fsync(orfdatasync), a trailing zero block is skipped and the file is grown withset_len()only after the sync, so the final length change is outside the requested synchronization. GNU dd extends the file first and then syncs.finalize()now callsextend_sparse()beforesync(). Added a Linux test that runs dd understrace(skipped when strace is missing or tracing isn't allowed, like the existing shred test) and checks that the finalftruncatecomes beforefsync/fdatasync.Closes #16552