Skip to content

utmpx: read logind sessions on static musl - #16682

Draft
mattsu2020 wants to merge 2 commits into
uutils:mainfrom
mattsu2020:utmpx/static-musl-logind
Draft

mattsu2020 wants to merge 2 commits into
uutils:mainfrom
mattsu2020:utmpx/static-musl-logind

Conversation

@mattsu2020

Copy link
Copy Markdown
Contributor

Static musl cannot load libsystemd at runtime. Read logind sessions over D-Bus on static musl and reuse the existing login record handling.

Depends on #11579. Related to #8376. Review the follow-up commit.

Tested against systemd 249 and 257. Stripped aarch64 musl release binaries grew by 640 KiB each for standalone who and pinky, and 576 KiB (5.3%) for multicall coreutils.

@oech3

oech3 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

If musl supported feat_require_unix_utmpx via systemd, feat_os_unix_musl should include those binaries too.

@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.55 MB (+164 KB, +0.10%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@codspeed

codspeed Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 7.67%

1 warning, 1 note

⚠️ 119 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ 1 benchmark has no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 262 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation socket_addrs_direct[100000] 104.8 µs 132.6 µs -20.97%
❌ CPU Simulation hostname_ip_lookup[100000] 155.7 µs 185.9 µs -16.21%
⚡ CPU Simulation true_consecutive_calls 350.2 ns 294.7 ns +18.85%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mattsu2020:utmpx/static-musl-logind (d5ff7fc) with main (293a724)2

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (722f540) during the generation of this report, so 293a724 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants