ci: fix upload-artifact version (v8 does not exist)#57
Merged
Conversation
resolvePath() normalizes path segments and drops trailing empty components, so a sed script like 's/world/there/' was rewritten to 's/world/there', losing the closing delimiter and producing 'unterminated substitute replacement'. Skip resolvePath for sed's script argument(s) (the first non-option arg, or args after -e/-f).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent "bump upload-artifcat" commit set
actions/upload-artifact@v8, but that version does not exist — the latest tag is v7 (v8 only exists fordownload-artifact). This broke all WASM build jobs with:Revert the three
upload-artifactreferences to@v7.download-artifact@v8is left as-is since that tag is valid.