Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces opt-in client-side caching for RPC calls by marking certain server RPC functions as cacheable and having the Rolldown DevTools client enable caching based on server-reported function metadata.
Changes:
- Mark multiple Rolldown RPC query/static functions as
cacheable: true. - Expose
cacheablemetadata via the internaldevtoolskit:internal:rpc:server:listRPC. - Add an RPC cache manager to the DevTools RPC client and enable/configure it from the Rolldown app at connect time.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/rolldown/src/node/rpc/functions/rolldown-list-sessions.ts | Mark list-sessions RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-session-summary.ts | Mark session summary RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-session-compare-summary.ts | Mark compare summary RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-plugin-details.ts | Mark plugin details RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-packages.ts | Mark packages RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-package-details.ts | Mark package details RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-module-info.ts | Mark module info RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-chunks-graph.ts | Mark chunks graph RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-chunk-info.ts | Mark chunk info RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-assets-list.ts | Mark assets list RPC as cacheable. |
| packages/rolldown/src/node/rpc/functions/rolldown-get-asset-details.ts | Mark asset details RPC as cacheable. |
| packages/rolldown/src/app/composables/rpc.ts | Enable caching and populate cacheable function list from server metadata. |
| packages/kit/src/client/rpc.ts | Add RpcCacheManager and intercept requests to serve/store cached responses. |
| packages/core/src/node/rpc/internal/rpc-server-list.ts | Include cacheable in server function listing payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
antfu
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.