Skip to content

nghttp3: enable static libraries - #60424

Closed
Arusekk wants to merge 2 commits into
void-linux:masterfrom
Arusekk:nghttp3-static
Closed

nghttp3: enable static libraries#60424
Arusekk wants to merge 2 commits into
void-linux:masterfrom
Arusekk:nghttp3-static

Conversation

@Arusekk

@Arusekk Arusekk commented May 8, 2026

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, x86_64

Fixes: c295bd2 ("New package: nghttp3-1.7.0")
@Duncaen

Duncaen commented May 10, 2026

Copy link
Copy Markdown
Member

Setting ENABLE_STATIC_LIB disables tests, which I don't think is a good idea.

https://github.com/ngtcp2/nghttp3/blob/e7a5a617ddf04b46eb7ce0ddaf3e318b1b46017d/CMakeOptions.txt#L10

@Arusekk

Arusekk commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Setting ENABLE_STATIC_LIB disables tests, which I don't think is a good idea.

https://github.com/ngtcp2/nghttp3/blob/e7a5a617ddf04b46eb7ce0ddaf3e318b1b46017d/CMakeOptions.txt#L10

cmake_dependent_option(BUILD_TESTING "Enable tests" ON "ENABLE_STATIC_LIB" OFF)

Actually it seems like it allows enabling tests:
https://cmake.org/cmake/help/latest/module/CMakeDependentOption.html#command:cmake_dependent_option

cmake_dependent_option(<variable> <help> <value> <condition> <else-value>)

@github-actions

Copy link
Copy Markdown

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions Bot added the Stale label Aug 13, 2026
@Arusekk

Arusekk commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Already done in 3c834d6. Thanks.

@Arusekk Arusekk closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants