Skip to content

viking: update to 1.11.#61184

Open
kpnc0 wants to merge 1 commit into
void-linux:masterfrom
kpnc0:viking-up
Open

viking: update to 1.11.#61184
kpnc0 wants to merge 1 commit into
void-linux:masterfrom
kpnc0:viking-up

Conversation

@kpnc0

@kpnc0 kpnc0 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

viking: update from 1.9 to 1.11.
adopted the package for maintenance

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-musl
  • I tested the map generation, and basic UI.

Comment thread srcpkgs/viking/template Outdated
Comment thread srcpkgs/viking/template Outdated
Comment thread srcpkgs/viking/template Outdated
@kpnc0 kpnc0 force-pushed the viking-up branch 3 times, most recently from dab6cc8 to de41281 Compare June 23, 2026 15:29
@kpnc0

kpnc0 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

"make_check=no" if it is alright

Removed obsolete patch, changed makedepends

Apply suggestion from @Duncaen

Co-authored-by: Duncan Overbruck <github@duncano.de>

- Move xxd from makedepends to hostmakedepends
- Remove outdated post_patch() vsed calls

viking: edits to pass the CI checks and pass the linter

 -appended --disable-ubsan to configure args
 -removed trailing empty line in template

implemented maket_check = no

Explaining why make_check is included
@kpnc0

kpnc0 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

The build succeeds for musl, but GCC handles UBsan differently, hence test fails for other distributions. Even "--disable-ubsan" is getting ignored.

@kpnc0 kpnc0 changed the title viking: update to 1.11. adopt viking: update to 1.11. Jun 23, 2026
@Duncaen

Duncaen commented Jun 23, 2026

Copy link
Copy Markdown
Member

Disabling all tests is not ok. If ubsan is the issue, you could patch that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants