test(snapshots): redact scaffolded devEngines version pins#2103
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
cpojer
approved these changes
Jul 9, 2026
Merge activity
|
vp create/migrate write the resolved runtime and package-manager version into a scaffolded package.json devEngines block, so recorded snapshots go stale whenever the package manager or Node publishes a release (yarn 4.17.0 -> 4.17.1 broke the create_approve_builds_yarn case). Mask the version value adjacent to a devEngines tool-name key (node/npm/pnpm/yarn/bun/deno), the same way the banner already masks "yarn <version>", and normalize the 9 existing pins across 5 snapshots. User-controlled semver in the same manifests (core-js, a pre-existing packageManager string, top-level version) stays verbatim.
graphite-app
Bot
force-pushed
the
fix/redact-scaffold-pm-version
branch
from
0f0a211 to
ab7f35b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vp create/migrate write the resolved runtime and package-manager version
into a scaffolded package.json devEngines block, so recorded snapshots go
stale whenever the package manager or Node publishes a release (yarn
4.17.0 -> 4.17.1 broke the create_approve_builds_yarn case).
Mask the version value adjacent to a devEngines tool-name key
(node/npm/pnpm/yarn/bun/deno), the same way the banner already masks
"yarn ", and normalize the 9 existing pins across 5 snapshots.
User-controlled semver in the same manifests (core-js, a pre-existing
packageManager string, top-level version) stays verbatim.